Skip to content

Commit 62898fe

Browse files
author
muha
committed
remove duplicate
1 parent 2cc0e40 commit 62898fe

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

client-credentials/src/main/java/com/example/config/HelseIDClientCredentialConfiguration.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.example.service.AuthorizationDetailsJwtClientParametersConverter;
66
import com.example.service.HelseIDClientCredentialTokenService;
77
import com.example.service.HelseIDDPoPClientCredentialTokenService;
8-
import java.time.Duration;
98
import lombok.extern.slf4j.Slf4j;
109
import org.springframework.beans.factory.annotation.Qualifier;
1110
import org.springframework.boot.autoconfigure.security.oauth2.client.ConditionalOnOAuth2ClientRegistrationProperties;
@@ -85,15 +84,14 @@ public HelseIDClientCredentialTokenService helseIDClientCredentialTokenService(
8584
OAuth2AuthorizedClientService oAuth2AuthorizedClientService,
8685
@Qualifier("authorizationCredentialsGrantResponseClient")
8786
OAuth2AccessTokenResponseClient<OAuth2ClientCredentialsGrantRequest>
88-
authorizationCredentialsGrantResponseClient) {
87+
tokenResponseClient) {
8988

9089
ClientRegistration clientRegistration =
9190
clientRegistrationRepository.findByRegistrationId(HELSEID_CREDENTIALS);
9291

9392
ClientCredentialsOAuth2AuthorizedClientProvider clientCredentialsAuthorizedClientProvider =
9493
new ClientCredentialsOAuth2AuthorizedClientProvider();
95-
clientCredentialsAuthorizedClientProvider.setAccessTokenResponseClient(
96-
authorizationCredentialsGrantResponseClient);
94+
clientCredentialsAuthorizedClientProvider.setAccessTokenResponseClient(tokenResponseClient);
9795

9896
return new HelseIDClientCredentialTokenService(
9997
clientRegistration,
@@ -108,20 +106,18 @@ public HelseIDDPoPClientCredentialTokenService helseIdApiDPOPClientCredentialTok
108106
DPoPProofBuilder dPoPProofBuilder,
109107
@Qualifier("authorizationCredentialsGrantResponseDpopClient")
110108
OAuth2AccessTokenResponseClient<OAuth2ClientCredentialsGrantRequest>
111-
authorizationCredentialsGrantResponseDpopClient) {
109+
dPoPTokenResponseClient) {
112110
ClientRegistration clientRegistration =
113111
clientRegistrationRepository.findByRegistrationId(HELSEID_CREDENTIALS);
114112

115113
ClientCredentialsOAuth2AuthorizedClientProvider clientCredentialsAuthorizedClientProvider =
116114
new ClientCredentialsOAuth2AuthorizedClientProvider();
117-
clientCredentialsAuthorizedClientProvider.setAccessTokenResponseClient(
118-
authorizationCredentialsGrantResponseDpopClient);
115+
clientCredentialsAuthorizedClientProvider.setAccessTokenResponseClient(dPoPTokenResponseClient);
119116

120117
return new HelseIDDPoPClientCredentialTokenService(
121118
clientRegistration,
122119
dPoPProofBuilder,
123120
oAuth2AuthorizedClientService,
124-
clientCredentialsAuthorizedClientProvider,
125-
Duration.ofMinutes(2));
121+
clientCredentialsAuthorizedClientProvider);
126122
}
127123
}

client-credentials/src/main/java/com/example/service/HelseIDDPoPClientCredentialTokenService.java

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
public class HelseIDDPoPClientCredentialTokenService {
2626

2727
private final Clock clock = Clock.systemUTC();
28-
private final Duration clockSkew;
28+
private final Duration clockSkew = Duration.ofSeconds(60);
2929
private final ClientRegistration clientRegistration;
3030
private final DPoPProofBuilder dPoPProofBuilder;
3131
private final OAuth2AuthorizedClientService oAuth2AuthorizedClientService;
@@ -37,16 +37,11 @@ public HelseIDDPoPClientCredentialTokenService(
3737
ClientRegistration clientRegistration,
3838
DPoPProofBuilder dPoPProofBuilder,
3939
OAuth2AuthorizedClientService oAuth2AuthorizedClientService,
40-
ClientCredentialsOAuth2AuthorizedClientProvider authorizedClientProvider,
41-
Duration refreshTokenBeforeSeconds) {
40+
ClientCredentialsOAuth2AuthorizedClientProvider authorizedClientProvider) {
4241
this.clientRegistration = clientRegistration;
42+
this.dPoPProofBuilder = dPoPProofBuilder;
4343
this.oAuth2AuthorizedClientService = oAuth2AuthorizedClientService;
44-
4544
clientCredentialsAuthorizedClientProvider = authorizedClientProvider;
46-
47-
this.clockSkew =
48-
refreshTokenBeforeSeconds != null ? refreshTokenBeforeSeconds : Duration.ofSeconds(60);
49-
this.dPoPProofBuilder = dPoPProofBuilder;
5045
}
5146

5247
public DPoPToken getAccessToken(String requestUrl, String requestMethod) {

0 commit comments

Comments
 (0)