Skip to content
This repository was archived by the owner on Jul 6, 2019. It is now read-only.

Commit 296d34a

Browse files
committed
ioreg: No need to read from write-only registers
1 parent 49bab5c commit 296d34a

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

ioreg/builder/setter.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,23 @@ fn build_drop<'a>(cx: &'a ExtCtxt, path: &Vec<String>,
122122
}
123123
}
124124

125+
// no need to read write-only registers
126+
let wo_reg: bool = fields.iter().all(|f| f.access == node::WriteOnly);
127+
let initial_value =
128+
if wo_reg {
129+
quote_expr!(cx, 0)
130+
} else {
131+
quote_expr!(cx, self.reg.value.get())
132+
};
133+
125134
let item = quote_item!(cx,
126135
#[unsafe_destructor]
127136
#[doc = "This performs the register update"]
128137
impl Drop for $setter_ty {
129138
fn drop(&mut self) {
130139
let clear_mask: $unpacked_ty = $clear as $unpacked_ty;
131140
if self.mask != 0 {
132-
let v: $unpacked_ty = self.reg.value.get() & ! clear_mask & ! self.mask;
141+
let v: $unpacked_ty = $initial_value & ! clear_mask & ! self.mask;
133142
self.reg.value.set(self.value | v);
134143
}
135144
}

0 commit comments

Comments
 (0)