Explicitely set uploaded image ACLs for S3 to "public-read"

djmaze · djmaze · commit 3fe6ec71e356 · 2019-12-05T18:37:42.000+01:00
This works around permission problems with DigitalOcean spaces (where
files are always *private* by default).

This should not pose a difference with AWS and other providers as CodiMD
only works with public S3 assets either way.

Signed-off-by: Martin Honermeyer &lt;maze@strahlungsfrei.de&gt;
diff --git a/lib/web/imageRouter/s3.js b/lib/web/imageRouter/s3.js
@@ -29,7 +29,8 @@ exports.uploadImage = function (imagePath, callback) {
     const params = {
       Bucket: config.s3bucket,
       Key: path.join('uploads', path.basename(imagePath)),
-      Body: buffer
+      Body: buffer,
+      ACL: 'public-read'
     }
 
     const mimeType = getImageMimeType(imagePath)

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ exports.uploadImage = function (imagePath, callback) {`
`29`	`29`	`const params = {`
`30`	`30`	`Bucket: config.s3bucket,`
`31`	`31`	`Key: path.join('uploads', path.basename(imagePath)),`
`32`		`- Body: buffer`
	`32`	`+ Body: buffer,`
	`33`	`+ ACL: 'public-read'`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`const mimeType = getImageMimeType(imagePath)`