fix: read proper version number (#659)

* fix: use the version number in package.json instead of having a VERSION file

* Delete VERSION file

* feat: remove all references to VERSION file

Author: pierreTklein

.eslintignore

@@ -2,4 +2,3 @@ assets/
 docs/
 node_modules/
 package-lock.json
-VERSION

.prettierignore

@@ -2,4 +2,3 @@ assets/
 docs/
 node_modules/
 package-lock.json
-VERSION

VERSION

@@ -6,7 +6,7 @@
 const app = require("../app").app;
 const debug = require("debug")("hackboard:server");
 const http = require("http");
-const fs = require("fs");
+const version = require("../services/version.service");
 
 /**
  * Get port from environment and store in Express.
@@ -75,12 +75,7 @@ function onListening() {
     const bind =
         typeof addr === "string" ? "pipe " + addr : "port " + addr.port;
     debug("Listening on " + bind);
-    fs.readFile("VERSION", function(err, data) {
-        if (err) {
-            throw err;
-        }
-        debug(`VERSION ${data}`);
-    });
+    debug(`VERSION ${version.get()}`);
 }
 
 /**

bin/www.js

@@ -23,7 +23,6 @@ Check out [this page](./getting-started).
 HackerAPI
 ├── Dockerfile:                     controls running of docker image
 ├── README.md:                      root of all information
-├── VERSION:                        version number of the application
 ├── app.js:                         express app object
 ├── bin
 │   └── www:                        entry point to the application
@@ -98,4 +97,4 @@ HackerAPI
         ├── staff.test.util.js
         ├── team.test.util.js
         └── volunteer.test.util.js
-```
+```

docs/index.md

@@ -1,10 +1,8 @@
 "use strict";
-const fs = require("fs");
-const path = require("path");
+const { version } = require("../package.json");
 
 const get = function() {
-    const version = fs.readFileSync(path.join(__dirname, "../VERSION"), "utf8");
-    return version.toString();
+    return version;
 };
 
 module.exports = {