feat: add school and status to team members list (#685)

* feat: add school and status to team members list

* fix test

* Update docs

Author: logan-r

controllers/team.controller.js

@@ -21,23 +21,11 @@ const Constants = {
 function showTeam(req, res) {
     const teamData = req.body.team.toJSON();
 
-    const memberNames = [];
-    for (const member of req.body.teamMembers) {
-        const strippedMemberJSON = member.toStrippedJSON();
-
-        const memberName = {
-            firstName: strippedMemberJSON.firstName,
-            lastName: strippedMemberJSON.lastName
-        };
-
-        memberNames.push(memberName);
-    }
-
     return res.status(200).json({
         message: Constants.Success.TEAM_READ,
         data: {
             team: teamData,
-            members: memberNames
+            members: req.body.teamMembers
         }
     });
 }

middlewares/team.middleware.js

@@ -419,7 +419,12 @@ async function populateMemberAccountsById(req, res, next) {
     let teamMembers = [];
 
     for (const member of team.members) {
-        teamMembers.push(member.accountId);
+        teamMembers.push({
+            school: member.application.general.school,
+            status: member.status,
+            firstName: member.accountId.firstName,
+            lastName: member.accountId.lastName
+        });
         hackerIds.push(member._id);
     }
     team.members = hackerIds;

package.json

@@ -3,11 +3,11 @@
     "version": "3.0.0",
     "private": true,
     "scripts": {
-        "start": "DEBUG=hackboard:* NODE_ENV=development nodemon --ignore gcp_creds.json ./bin/www.js",
+        "start": "DEBUG=hackboard:* NODE_ENV=test nodemon --ignore gcp_creds.json ./bin/www.js",
         "deploy": "NODE_ENV=deployment node ./bin/www.js",
-        "debug": "DEBUG=hackboard:* NODE_ENV=deployment nodemon --ignore gcp_creds.json ./bin/www.js",
+        "debug": "DEBUG=hackboard:* NODE_ENV=test nodemon --ignore gcp_creds.json ./bin/www.js",
         "test": "DEBUG=hackboard:* NODE_ENV=test mocha --reporter spec tests/**.js --exit",
-        "seed": "NODE_ENV=development node ./seed/index.js",
+        "seed": "NODE_ENV=test node ./seed/index.js",
         "docs": "apidoc -i ./routes -o ./docs/api/",
         "format": "prettier --write '**/*.js'",
         "lint": "eslint --fix '**/*.js'"

routes/api/team.js

@@ -21,7 +21,7 @@ const Services = {
 };
 
 module.exports = {
-    activate: function(apiRouter) {
+    activate: function (apiRouter) {
         const teamRouter = new express.Router();
 
         /**
@@ -137,7 +137,9 @@ module.exports = {
                         "members": [
                             {
                                 "firstName": "John",
-                                "lastName": "Doe"
+                                "lastName": "Doe",
+                                "school": "McGill University",
+                                "status": "Applied"
                             }
                         ],
                     }