fix: properly load env in ci (#772)

* fix: properly load env in ci

* refactor: remove unused comment

Author: logan-r

package.json

@@ -7,7 +7,7 @@
         "start-windows": "set DEBUG=hackboard:* && set NODE_ENV=test && nodemon --ignore gcp_creds.json ./bin/www.js",
         "deploy": "NODE_ENV=deployment node ./bin/www.js",
         "debug": "DEBUG=hackboard:* NODE_ENV=test nodemon --ignore gcp_creds.json ./bin/www.js",
-        "test": "DEBUG=hackboard:* NODE_ENV=test mocha --reporter spec tests/**.js --exit",
+        "test": "DEBUG=hackboard:* NODE_ENV=test mocha -r dotenv/config --reporter spec tests/**.js --exit",
         "seed": "NODE_ENV=test node ./seed/index.js",
         "docs": "apidoc -i ./routes -o ./docs/api/",
         "format": "prettier --write '**/*.js'",

tests/email.service.spec.js

@@ -1,9 +1,6 @@
 "use strict";
 const dotenv = require("dotenv");
 const path = require("path");
-dotenv.config({
-    path: path.join(__dirname, "../.env")
-});
 const EmailService = require("../services/email.service");
 const assert = require("chai").assert;
 

tests/storage.spec.js

@@ -1,7 +1,8 @@
 "use strict";
 const path = require("path");
 //load up env variables
-require("../services/env.service").load(path.join(__dirname, "../.env"));
+const dotenv = require("dotenv");
+require("../services/env.service").load(dotenv);
 
 const StorageService = require("../services/storage.service");