Skip to content

Commit 2e3fd15

Browse files
authored
fix: application submitted page not being shown due to failed confirmation check. (#780)
- forgotten account confirmation check on the findSelf function in the hacker middleware allowed constant 409 requests. - IMPORTANT: this issue has a ripple effect in the sponsor and volunteer middleware from what i understand as the code is the same in the findSelf functions in both classes. - i would recommend patching both or resolving the e-mail billing issue before the sponsor and volunteer onboarding.
1 parent a5e29a2 commit 2e3fd15

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

middlewares/hacker.middleware.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -841,8 +841,7 @@ async function checkDuplicateAccountLinks(req, res, next) {
841841
*/
842842
async function findSelf(req, res, next) {
843843
if (
844-
req.user.accountType != Constants.General.HACKER ||
845-
!req.user.confirmed
844+
req.user.accountType != Constants.General.HACKER /*|| !req.user.confirmed*/
846845
) {
847846
return next({
848847
status: 409,

0 commit comments

Comments
 (0)