test(Support): update JsonFixer test

- Update JsonFixer test
- Use chained assertions to improve readability
- Fix deprecated usage of JSON_THROW_ON_ERROR

Author: guanguans

tests/Support/HeplersTest.php

@@ -15,21 +15,22 @@
 use Laravel\Lumen\Application;
 
 it('can explode env', function (): void {
-    expect(env_explode('ENV_EXPLODE_STRING'))->toBeArray()->toBeTruthy();
-    expect(env_explode('ENV_EXPLODE_EMPTY'))->toBe(['']);
-    expect(env_explode('ENV_EXPLODE_NOT_EXIST'))->toBeNull();
-    // expect(env_explode('ENV_EXPLODE_TRUE'))->toBeTrue();
-    // expect(env_explode('ENV_EXPLODE_FALSE'))->toBeFalse();
-    // expect(env_explode('ENV_EXPLODE_NULL'))->toBeNull();
+    expect(env_explode('ENV_EXPLODE_STRING'))->toBeArray()->toBeTruthy()
+        ->and(env_explode('ENV_EXPLODE_EMPTY'))->toBe([''])
+        ->and(env_explode('ENV_EXPLODE_NOT_EXIST'))->toBeNull()
+        // ->and(env_explode('ENV_EXPLODE_TRUE'))->toBeTrue()
+        // ->and(env_explode('ENV_EXPLODE_FALSE'))->toBeFalse()
+        // ->and(env_explode('ENV_EXPLODE_NULL'))->toBeNull()
+    ;
 })->group(__DIR__, __FILE__);
 
 it('can return Stringable', function (): void {
-    expect(str())->toBeInstanceOf(Stringable::class);
-    expect(str('foo'))->toBeInstanceOf(Illuminate\Support\Stringable::class);
+    expect(str())->toBeInstanceOf(Stringable::class)
+        ->and(str('foo'))->toBeInstanceOf(Illuminate\Support\Stringable::class);
 })->group(__DIR__, __FILE__);
 
 it('can is lumen', function (): void {
-    expect(is_lumen())->toBeFalse();
-    expect(is_lumen(app()))->toBeFalse();
-    expect(is_lumen(app(Application::class)))->toBeTrue();
+    expect(is_lumen())->toBeFalse()
+        ->and(is_lumen(app()))->toBeFalse()
+        ->and(is_lumen(app(Application::class)))->toBeTrue();
 })->group(__DIR__, __FILE__);

tests/Support/JsonFixerTest.php

@@ -19,18 +19,15 @@
 })->group(__DIR__, __FILE__)->with('InvalidJsons');
 
 it('can fix invalid json with missing value', function (): void {
-    expect(new JsonFixer())
-        ->missingValue('')
-        ->fix(substr(json_encode([1, 2, 3]), 0, 5))->toBeJson();
-
-    expect(new JsonFixer())
-        ->silent()
-        ->fix($json = substr(json_encode([1, 2, 3]), 3))->toBe($json)
+    expect(new JsonFixer())->missingValue('')
+        ->fix(substr(json_encode([1, 2, 3], JSON_THROW_ON_ERROR), 0, 5))->toBeJson()
+        ->and(new JsonFixer())
+        ->silent()->fix($json = substr(json_encode([1, 2, 3], JSON_THROW_ON_ERROR), 3))->toBe($json)
         ->not->toBeJson();
 })->group(__DIR__, __FILE__);
 
 it('will throw RuntimeException', function (): void {
     (new JsonFixer())
         ->silent(false)
-        ->fix(substr(json_encode([1, 2, 3]), 3));
+        ->fix(substr(json_encode([1, 2, 3], JSON_THROW_ON_ERROR), 3));
 })->group(__DIR__, __FILE__)->throws(RuntimeException::class, 'Could not fix JSON (tried padding ``)');

tests/TestCase.php

@@ -49,11 +49,6 @@ class TestCase extends \Orchestra\Testbench\TestCase
     use PHPMock;
     use VarDumperTestTrait;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
     protected function tearDown(): void
     {
         parent::tearDown();
@@ -64,7 +59,7 @@ protected function tearDown(): void
         \Mockery::close();
     }
 
-    protected function getPackageProviders($app)
+    protected function getPackageProviders($app): array
     {
         return [
             ExceptionNotifyServiceProvider::class,
@@ -107,12 +102,12 @@ protected function defineEnvironment($app): void
 
     protected function defineRoutes($router): void
     {
-        $router->any('report-exception', static fn () => tap(response('report-exception'), function (): void {
+        $router->any('report-exception', static fn () => tap(response('report-exception'), static function (): void {
             ExceptionNotify::report(new \Exception('What happened?'), ['bark', 'dump', 'null']);
         }));
 
-        $router->any('exception', static fn () => tap(response('exception'), function (): void {
-            throw new \Exception('What happened?');
+        $router->any('exception', static fn () => tap(response('exception'), static function (): void {
+            throw new \RuntimeException('What happened?');
         }));
     }
 }