logs the metrics inside sync context

Author: AgraVator

core/src/main/java/io/grpc/internal/DelayedClientTransport.java

@@ -201,8 +201,8 @@ public ListenableFuture<SocketStats> getStats() {
   }
 
   /**
-   * Prevents creating any new streams.  Buffered streams are not failed and may still proceed
-   * when {@link #reprocess} is called.  The delayed transport will be terminated when there is no
+   * Prevents creating any new streams. Buffered streams are not failed and may still proceed
+   * when {@link #reprocess} is called. The delayed transport will be terminated when there is no
    * more buffered streams.
    */
   @Override

core/src/main/java/io/grpc/internal/InternalSubchannel.java

@@ -588,15 +588,6 @@ public Attributes filterTransport(Attributes attributes) {
     @Override
     public void transportReady() {
       channelLogger.log(ChannelLogLevel.INFO, "READY");
-      subchannelMetrics.recordConnectionAttemptSucceeded(buildLabelSet(
-          getAttributeOrDefault(
-              addressIndex.getCurrentEagAttributes(), NameResolver.ATTR_BACKEND_SERVICE),
-          getAttributeOrDefault(
-              addressIndex.getCurrentEagAttributes(), LoadBalancer.ATTR_LOCALITY_NAME),
-          null,
-          extractSecurityLevel(
-              addressIndex.getCurrentEagAttributes().get(GrpcAttributes.ATTR_SECURITY_LEVEL))
-      ));
       syncContext.execute(new Runnable() {
         @Override
         public void run() {
@@ -633,22 +624,6 @@ public void transportShutdown(final Status s) {
       channelLogger.log(
           ChannelLogLevel.INFO, "{0} SHUTDOWN with {1}", transport.getLogId(), printShortStatus(s));
       shutdownInitiated = true;
-      subchannelMetrics.recordConnectionAttemptFailed(buildLabelSet(
-          getAttributeOrDefault(
-              addressIndex.getCurrentEagAttributes(), NameResolver.ATTR_BACKEND_SERVICE),
-          getAttributeOrDefault(
-              addressIndex.getCurrentEagAttributes(), LoadBalancer.ATTR_LOCALITY_NAME),
-          null, null
-          ));
-      subchannelMetrics.recordDisconnection(buildLabelSet(
-          getAttributeOrDefault(
-              addressIndex.getCurrentEagAttributes(), NameResolver.ATTR_BACKEND_SERVICE),
-          getAttributeOrDefault(
-              addressIndex.getCurrentEagAttributes(), LoadBalancer.ATTR_LOCALITY_NAME),
-          "Peer Pressure",
-          extractSecurityLevel(
-              addressIndex.getCurrentEagAttributes().get(GrpcAttributes.ATTR_SECURITY_LEVEL))
-      ));
       syncContext.execute(new Runnable() {
         @Override
         public void run() {