allow java21 in jre matrix (#12281)

Author: shivaspeaks

.github/workflows/testing.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        jre: [8, 11, 17]
+        jre: [8, 11, 17, 21]
       fail-fast: false # Should swap to true if we grow a large matrix
 
     steps:

api/src/main/java/io/grpc/StatusException.java

@@ -25,7 +25,9 @@
  */
 public class StatusException extends Exception {
   private static final long serialVersionUID = -660954903976144640L;
+  @SuppressWarnings("serial")   // https://github.com/grpc/grpc-java/issues/1913
   private final Status status;
+  @SuppressWarnings("serial")
   private final Metadata trailers;
 
   /**

api/src/main/java/io/grpc/StatusRuntimeException.java

@@ -26,7 +26,9 @@
 public class StatusRuntimeException extends RuntimeException {
 
   private static final long serialVersionUID = 1950934672280720624L;
+  @SuppressWarnings("serial")   // https://github.com/grpc/grpc-java/issues/1913
   private final Status status;
+  @SuppressWarnings("serial")
   private final Metadata trailers;
 
   /**

core/src/main/java/io/grpc/internal/AbstractClientStream.java

@@ -101,6 +101,7 @@ void writeFrame(
    */
   private volatile boolean cancelled;
 
+  @SuppressWarnings("this-escape")
   protected AbstractClientStream(
       WritableBufferAllocator bufferAllocator,
       StatsTraceContext statsTraceCtx,
@@ -113,7 +114,7 @@ protected AbstractClientStream(
     this.shouldBeCountedForInUse = GrpcUtil.shouldBeCountedForInUse(callOptions);
     this.useGet = useGet;
     if (!useGet) {
-      framer = new MessageFramer(this, bufferAllocator, statsTraceCtx);
+      this.framer = new MessageFramer(this, bufferAllocator, statsTraceCtx);
       this.headers = headers;
     } else {
       framer = new GetFramer(headers, statsTraceCtx);

core/src/main/java/io/grpc/internal/AbstractServerStream.java

@@ -75,10 +75,11 @@ protected interface Sink {
   private boolean outboundClosed;
   private boolean headersSent;
 
+  @SuppressWarnings("this-escape")
   protected AbstractServerStream(
       WritableBufferAllocator bufferAllocator, StatsTraceContext statsTraceCtx) {
     this.statsTraceCtx = Preconditions.checkNotNull(statsTraceCtx, "statsTraceCtx");
-    framer = new MessageFramer(this, bufferAllocator, statsTraceCtx);
+    this.framer = new MessageFramer(this, bufferAllocator, statsTraceCtx);
   }
 
   @Override

core/src/main/java/io/grpc/internal/AbstractStream.java

@@ -163,20 +163,21 @@ public abstract static class TransportState
     @GuardedBy("onReadyLock")
     private int onReadyThreshold;
 
+    @SuppressWarnings("this-escape")
     protected TransportState(
         int maxMessageSize,
         StatsTraceContext statsTraceCtx,
         TransportTracer transportTracer) {
       this.statsTraceCtx = checkNotNull(statsTraceCtx, "statsTraceCtx");
       this.transportTracer = checkNotNull(transportTracer, "transportTracer");
-      rawDeframer = new MessageDeframer(
+      this.rawDeframer = new MessageDeframer(
           this,
           Codec.Identity.NONE,
           maxMessageSize,
           statsTraceCtx,
           transportTracer);
       // TODO(#7168): use MigratingThreadDeframer when enabling retry doesn't break.
-      deframer = rawDeframer;
+      deframer = this.rawDeframer;
       onReadyThreshold = DEFAULT_ONREADY_THRESHOLD;
     }
 

core/src/main/java/io/grpc/internal/JsonUtil.java

@@ -356,7 +356,7 @@ private static int parseNanos(String value) throws ParseException {
     return result;
   }
 
-  private static final long NANOS_PER_SECOND = TimeUnit.SECONDS.toNanos(1);
+  private static final int NANOS_PER_SECOND = 1_000_000_000;
 
   /**
    * Copy of {@link com.google.protobuf.util.Durations#normalizedDuration}.
@@ -368,11 +368,11 @@ private static long normalizedDuration(long seconds, int nanos) {
       nanos %= NANOS_PER_SECOND;
     }
     if (seconds > 0 && nanos < 0) {
-      nanos += NANOS_PER_SECOND; // no overflow since nanos is negative (and we're adding)
+      nanos += NANOS_PER_SECOND; // no overflow— nanos is negative (and we're adding)
       seconds--; // no overflow since seconds is positive (and we're decrementing)
     }
     if (seconds < 0 && nanos > 0) {
-      nanos -= NANOS_PER_SECOND; // no overflow since nanos is positive (and we're subtracting)
+      nanos -= NANOS_PER_SECOND; // no overflow— nanos is positive (and we're subtracting)
       seconds++; // no overflow since seconds is negative (and we're incrementing)
     }
     if (!durationIsValid(seconds, nanos)) {

inprocess/src/main/java/io/grpc/inprocess/AnonymousInProcessSocketAddress.java

@@ -21,6 +21,8 @@
 import com.google.errorprone.annotations.concurrent.GuardedBy;
 import io.grpc.ExperimentalApi;
 import java.io.IOException;
+import java.io.NotSerializableException;
+import java.io.ObjectOutputStream;
 import java.net.SocketAddress;
 import javax.annotation.Nullable;
 
@@ -34,8 +36,13 @@ public final class AnonymousInProcessSocketAddress extends SocketAddress {
 
   @Nullable
   @GuardedBy("this")
+  @SuppressWarnings("serial")
   private InProcessServer server;
 
+  private void writeObject(ObjectOutputStream out) throws IOException {
+    throw new NotSerializableException("AnonymousInProcessSocketAddress is not serializable");
+  }
+
   /** Creates a new AnonymousInProcessSocketAddress. */
   public AnonymousInProcessSocketAddress() { }
 

netty/src/main/java/io/grpc/netty/GrpcHttp2ConnectionHandler.java

@@ -68,6 +68,7 @@ public abstract class GrpcHttp2ConnectionHandler extends Http2ConnectionHandler
     usingPre4_1_111_Netty = identifiedOldVersion;
   }
 
+  @SuppressWarnings("this-escape")
   protected GrpcHttp2ConnectionHandler(
       ChannelPromise channelUnused,
       Http2ConnectionDecoder decoder,

servlet/src/main/java/io/grpc/servlet/GrpcServlet.java

@@ -37,6 +37,7 @@
 public class GrpcServlet extends HttpServlet {
   private static final long serialVersionUID = 1L;
 
+  @SuppressWarnings("serial")
   private final ServletAdapter servletAdapter;
 
   GrpcServlet(ServletAdapter servletAdapter) {