Fixes error code limosa-io#74 (limosa-io#101)

Author: arietimmerman

src/Attribute/Constant.php

@@ -32,7 +32,7 @@ public function replace($value, &$object, $path = null)
         $current = json_encode($this->read($object)?->value);
 
         if (json_encode($value) != $current) {
-            throw (new SCIMException(sprintf('Write to "%s" is not supported, tried to change "%s" to "%s"', $this->getFullKey(), $current, json_encode($value))))->setCode(500)->setScimType('mutability');
+            throw (new SCIMException(sprintf('Write to "%s" is not supported, tried to change "%s" to "%s"', $this->getFullKey(), $current, json_encode($value))))->setCode(403)->setScimType('mutability');
         }
 
         $this->dirty = true;

src/Http/Controllers/ResourceController.php

@@ -51,7 +51,7 @@ protected static function validateScim(ResourceType $resourceType, $flattened, ?
     public static function createFromSCIM($resourceType, $input, PolicyDecisionPoint $pdp = null, Request $request = null, $allowAlways = false, $isMe = false)
     {
         if (!isset($input['schemas']) || !is_array($input['schemas'])) {
-            throw (new SCIMException('Missing a valid schemas-attribute.'))->setCode(500);
+            throw (new SCIMException('Missing a valid schemas-attribute.'))->setCode(400);
         }
 
         $flattened = Helper::flatten($input, $input['schemas']);

tests/GroupsTest.php

@@ -142,4 +142,9 @@ public function testBulk(){
         // confirm testgroup1 exists
         $this->assertNotNull(Group::where('displayName', 'TestGroup2')->first());
     }
+
+    public function testGroupCreationFailure(){
+        $response = $this->post('/scim/v2/Groups', []);
+        $response->assertStatus(400);
+    }
 }