Prevent implicit cast for non-int underlying type

oiffrig · oiffrig · commit c3ba7290e3f1 · 2017-08-01T15:09:02.000+02:00
diff --git a/include/flags/flags.hpp b/include/flags/flags.hpp
@@ -140,15 +140,15 @@ template <class E> struct flags {
   }
 
   friend constexpr flags operator|(flags f1, flags f2) noexcept {
-    return flags{f1.val_ | f2.val_};
+    return flags{static_cast<impl_type>(f1.val_ | f2.val_)};
   }
 
   friend constexpr flags operator&(flags f1, flags f2) noexcept {
-    return flags{f1.val_ & f2.val_};
+    return flags{static_cast<impl_type>(f1.val_ & f2.val_)};
   }
 
   friend  constexpr flags operator^(flags f1, flags f2) noexcept {
-    return flags{f1.val_ ^ f2.val_};
+    return flags{static_cast<impl_type>(f1.val_ ^ f2.val_)};
   }
 
 

Original file line number	Diff line number	Diff line change
`@@ -140,15 +140,15 @@ template <class E> struct flags {`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`friend constexpr flags operator\|(flags f1, flags f2) noexcept {`
`143`		`- return flags{f1.val_ \| f2.val_};`
	`143`	`+ return flags{static_cast<impl_type>(f1.val_ \| f2.val_)};`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`friend constexpr flags operator&(flags f1, flags f2) noexcept {`
`147`		`- return flags{f1.val_ & f2.val_};`
	`147`	`+ return flags{static_cast<impl_type>(f1.val_ & f2.val_)};`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`friend constexpr flags operator^(flags f1, flags f2) noexcept {`
`151`		`- return flags{f1.val_ ^ f2.val_};`
	`151`	`+ return flags{static_cast<impl_type>(f1.val_ ^ f2.val_)};`
`152`	`152`	`}`
`153`	`153`
`154`	`154`