Skip to content

Commit 757a9c4

Browse files
committed
Replace --skip-system-scope with --skip-os-packages
1 parent 360568e commit 757a9c4

21 files changed

+59
-55
lines changed

docs/guides/troubleshooting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ python3 -m dependency_resolver host --debug
208208
# Docker analysis with debug
209209
python3 -m dependency_resolver docker container_name --debug
210210

211-
# Skip system scope for faster testing
211+
# Skip OS Packages for faster testing
212212
python3 -m dependency_resolver --skip-os-packages --debug
213213

214214
# Test specific working directory

performance-analysis/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ The detector-specific benchmark scripts are located in the `detectors/` subdirec
112112

113113
Profiles dependency resolution on the host system with interface selection support:
114114

115-
- Skip system scope (fast, ~40 packages)
115+
- Skip OS Packages (fast, ~40 packages)
116116
- Full system scan (slow, ~2700 packages)
117117
- CLI and programmatic interface support
118118
- System information collection (CPU, memory, versions)

performance-analysis/detector-benchmarks.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ show_usage() {
8484
echo "OPTIONS:"
8585
echo " -h, --help Show this help message"
8686
echo " --clean Clean existing profiles before running"
87-
echo " --skip-system-check Skip system dependency checks"
87+
echo " --skip-os-packages Skip os packages checks"
8888
echo " --skip-hash-collection Skip hash collection for faster execution"
8989
echo " --profiling Enable detailed profiling (slower, for analysis)"
9090
echo " --interface TYPE Interface type: 'cli' or 'programmatic' (default: cli)"
@@ -113,7 +113,7 @@ show_usage() {
113113
DETECTOR_TYPE="all"
114114
SPECIFIC_SCENARIO="all"
115115
CLEAN_PROFILES=false
116-
SKIP_SYSTEM_CHECK=false
116+
SKIP_OS_PACKAGES_CHECK=false
117117
SKIP_HASH_COLLECTION=false
118118
ENABLE_PROFILING=false
119119
INTERFACE="cli"
@@ -129,8 +129,8 @@ while [[ $# -gt 0 ]]; do
129129
CLEAN_PROFILES=true
130130
shift
131131
;;
132-
--skip-system-check)
133-
SKIP_SYSTEM_CHECK=true
132+
--skip-os-packages)
133+
SKIP_OS_PACKAGES_CHECK=true
134134
shift
135135
;;
136136
--skip-hash-collection)
@@ -384,7 +384,7 @@ main() {
384384
echo "Profiling enabled: ${ENABLE_PROFILING}"
385385
echo ""
386386

387-
if [[ "$SKIP_SYSTEM_CHECK" == false ]]; then
387+
if [[ "$SKIP_OS_PACKAGES_CHECK" == false ]]; then
388388
check_prerequisites
389389
fi
390390

performance-analysis/detectors/host-benchmarks.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,15 @@ fi
6969
case $SCENARIO_TYPE in
7070
"skip-system")
7171
if [[ "$INTERFACE" == "cli" ]]; then
72-
cmd="cd '$PROJECT_ROOT' && python3 -m dependency_resolver host --skip-system-scope"
72+
cmd="cd '$PROJECT_ROOT' && python3 -m dependency_resolver host --skip-os-packages"
7373
[[ -n "$HASH_FLAG" ]] && cmd="$cmd $HASH_FLAG"
7474
[[ -n "$SELECT_FLAG" ]] && cmd="$cmd $SELECT_FLAG"
75-
host_benchmark_scenario "Host Skip System Scope ($INTERFACE)" \
75+
host_benchmark_scenario "Host Skip OS Packages ($INTERFACE)" \
7676
"$cmd" \
7777
30
7878
else
79-
host_benchmark_scenario "Host Skip System Scope ($INTERFACE)" \
80-
"cd '$PROJECT_ROOT' && python3 -c 'import dependency_resolver; print(dependency_resolver.resolve_host_dependencies(skip_system_scope=True$HASH_ARG$SELECT_ARG))'" \
79+
host_benchmark_scenario "Host Skip OS Packages ($INTERFACE)" \
80+
"cd '$PROJECT_ROOT' && python3 -c 'import dependency_resolver; print(dependency_resolver.resolve_host_dependencies(skip_os_packages=True$HASH_ARG$SELECT_ARG))'" \
8181
30
8282
fi
8383
;;
@@ -97,10 +97,10 @@ case $SCENARIO_TYPE in
9797
;;
9898
"all")
9999
if [[ "$INTERFACE" == "cli" ]]; then
100-
cmd1="cd '$PROJECT_ROOT' && python3 -m dependency_resolver host --skip-system-scope"
100+
cmd1="cd '$PROJECT_ROOT' && python3 -m dependency_resolver host --skip-os-packages"
101101
[[ -n "$HASH_FLAG" ]] && cmd1="$cmd1 $HASH_FLAG"
102102
[[ -n "$SELECT_FLAG" ]] && cmd1="$cmd1 $SELECT_FLAG"
103-
host_benchmark_scenario "Host Skip System Scope ($INTERFACE)" \
103+
host_benchmark_scenario "Host Skip OS Packages ($INTERFACE)" \
104104
"$cmd1" \
105105
30
106106

@@ -112,8 +112,8 @@ case $SCENARIO_TYPE in
112112
60
113113
else
114114
# Programmatic interface
115-
host_benchmark_scenario "Host Skip System Scope ($INTERFACE)" \
116-
"cd '$PROJECT_ROOT' && python3 -c 'import dependency_resolver; print(dependency_resolver.resolve_host_dependencies(skip_system_scope=True$HASH_ARG$SELECT_ARG))'" \
115+
host_benchmark_scenario "Host Skip OS Packages ($INTERFACE)" \
116+
"cd '$PROJECT_ROOT' && python3 -c 'import dependency_resolver; print(dependency_resolver.resolve_host_dependencies(skip_os_packages=True$HASH_ARG$SELECT_ARG))'" \
117117
30
118118

119119
host_benchmark_scenario "Host Full System ($INTERFACE)" \

performance-analysis/performance-optimization-analysis.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Performance profiling using py-spy identified significant optimization opportuni
1717
- **Tool**: py-spy v0.4.1 with flame graph generation
1818
- **Environment**: Ubuntu 24.04 host system
1919
- **Test Cases**:
20-
- Host with pip only (`--skip-system-scope`): 39 packages
20+
- Host with pip only (`--skip-os-packages`): 39 packages
2121
- Host with full system: 2700+ dpkg packages
2222

2323
### Performance Measurements
@@ -26,7 +26,7 @@ Performance profiling using py-spy identified significant optimization opportuni
2626

2727
| Configuration | Execution Time | Package Count | Primary Detector |
2828
|---------------|----------------|---------------|------------------|
29-
| `host --skip-system-scope` | **1.942s** | 39 pip packages | PipDetector |
29+
| `host --skip-os-packages` | **1.942s** | 39 pip packages | PipDetector |
3030
| `host` (full system) | **~20+ seconds** | 2700+ dpkg packages | DpkgDetector |
3131

3232
#### Docker Environment
@@ -365,7 +365,7 @@ This implementation successfully achieves the predicted performance improvements
365365

366366
| Configuration | Current Time | Package Count | Improvement vs Original |
367367
|---------------|--------------|---------------|------------------------|
368-
| `host --skip-system-scope` | **1.507s** | 39 pip packages | **22.4% faster** (vs 1.942s) |
368+
| `host --skip-os-packages` | **1.507s** | 39 pip packages | **22.4% faster** (vs 1.942s) |
369369
| `host` (full system) | **2.161s** | 870 dpkg packages | **~90% faster** (vs ~20+ seconds) |
370370

371371
#### Package Manager Specific Performance (2025-08-18 Measurements)

performance-analysis/profiles/debug_mode_profile.svg

Lines changed: 1 addition & 1 deletion
Loading

performance-analysis/profiles/docker_python_pip.svg

Lines changed: 1 addition & 1 deletion
Loading

performance-analysis/profiles/host_skip_system_baseline.svg

Lines changed: 1 addition & 1 deletion
Loading

performance-analysis/profiles/npm_large_packages.svg

Lines changed: 1 addition & 1 deletion
Loading

performance-analysis/profiles/npm_small_packages.svg

Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)