From 2929b135ae659b9334334f3e51db444c976cdcb7 Mon Sep 17 00:00:00 2001 From: Benjie Gillam Date: Thu, 22 May 2025 14:13:48 +0100 Subject: [PATCH] Minor validation tweaks from review --- src/type/validate.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/type/validate.ts b/src/type/validate.ts index 0a8193d501..ede99c8054 100644 --- a/src/type/validate.ts +++ b/src/type/validate.ts @@ -812,7 +812,7 @@ function createInputObjectDefaultValueCircularRefsValidator( ): void { // Start with an empty object as a way to visit every field in this input // object type and apply every default value. - return detectValueDefaultValueCycle(inputObj, {}); + return detectValueDefaultValueCycle(inputObj, Object.create(null)); }; function detectValueDefaultValueCycle( @@ -910,7 +910,7 @@ function createInputObjectDefaultValueCircularRefsValidator( // Check to see if there is cycle. const cycleIndex = fieldPathIndex[fieldStr]; - if (cycleIndex !== undefined && cycleIndex > 0) { + if (cycleIndex !== undefined) { context.reportError( `Invalid circular reference. The default value of Input Object field ${fieldStr} references itself${ cycleIndex < fieldPath.length