rename FieldGroup type to FieldDetailsList (#4216)

Author: yaacovCR

src/execution/buildExecutionPlan.ts

@@ -3,7 +3,7 @@ import { isSameSet } from '../jsutils/isSameSet.js';
 
 import type {
   DeferUsage,
-  FieldGroup,
+  FieldDetailsList,
   GroupedFieldSet,
 } from './collectFields.js';
 
@@ -18,13 +18,16 @@ export function buildExecutionPlan(
   originalGroupedFieldSet: GroupedFieldSet,
   parentDeferUsages: DeferUsageSet = new Set<DeferUsage>(),
 ): ExecutionPlan {
-  const groupedFieldSet = new Map<string, FieldGroup>();
-  const newGroupedFieldSets = new Map<DeferUsageSet, Map<string, FieldGroup>>();
-  for (const [responseKey, fieldGroup] of originalGroupedFieldSet) {
-    const filteredDeferUsageSet = getFilteredDeferUsageSet(fieldGroup);
+  const groupedFieldSet = new Map<string, FieldDetailsList>();
+  const newGroupedFieldSets = new Map<
+    DeferUsageSet,
+    Map<string, FieldDetailsList>
+  >();
+  for (const [responseKey, fieldDetailsList] of originalGroupedFieldSet) {
+    const filteredDeferUsageSet = getFilteredDeferUsageSet(fieldDetailsList);
 
     if (isSameSet(filteredDeferUsageSet, parentDeferUsages)) {
-      groupedFieldSet.set(responseKey, fieldGroup);
+      groupedFieldSet.set(responseKey, fieldDetailsList);
       continue;
     }
 
@@ -36,7 +39,7 @@ export function buildExecutionPlan(
       newGroupedFieldSet = new Map();
       newGroupedFieldSets.set(filteredDeferUsageSet, newGroupedFieldSet);
     }
-    newGroupedFieldSet.set(responseKey, fieldGroup);
+    newGroupedFieldSet.set(responseKey, fieldDetailsList);
   }
 
   return {
@@ -46,10 +49,10 @@ export function buildExecutionPlan(
 }
 
 function getFilteredDeferUsageSet(
-  fieldGroup: FieldGroup,
+  fieldDetailsList: FieldDetailsList,
 ): ReadonlySet<DeferUsage> {
   const filteredDeferUsageSet = new Set<DeferUsage>();
-  for (const fieldDetails of fieldGroup) {
+  for (const fieldDetails of fieldDetailsList) {
     const deferUsage = fieldDetails.deferUsage;
     if (deferUsage === undefined) {
       filteredDeferUsageSet.clear();

src/execution/collectFields.ts

@@ -39,9 +39,9 @@ export interface FieldDetails {
   fragmentVariableValues?: VariableValues | undefined;
 }
 
-export type FieldGroup = ReadonlyArray<FieldDetails>;
+export type FieldDetailsList = ReadonlyArray<FieldDetails>;
 
-export type GroupedFieldSet = ReadonlyMap<string, FieldGroup>;
+export type GroupedFieldSet = ReadonlyMap<string, FieldDetailsList>;
 
 export interface FragmentDetails {
   definition: FragmentDefinitionNode;
@@ -113,7 +113,7 @@ export function collectSubfields(
   variableValues: VariableValues,
   operation: OperationDefinitionNode,
   returnType: GraphQLObjectType,
-  fieldGroup: FieldGroup,
+  fieldDetailsList: FieldDetailsList,
 ): {
   groupedFieldSet: GroupedFieldSet;
   newDeferUsages: ReadonlyArray<DeferUsage>;
@@ -129,7 +129,7 @@ export function collectSubfields(
   const subGroupedFieldSet = new AccumulatorMap<string, FieldDetails>();
   const newDeferUsages: Array<DeferUsage> = [];
 
-  for (const fieldDetail of fieldGroup) {
+  for (const fieldDetail of fieldDetailsList) {
     const selectionSet = fieldDetail.node.selectionSet;
     if (selectionSet) {
       const { deferUsage, fragmentVariableValues } = fieldDetail;