f

Author: yaacovCR

src/execution/execute.ts

@@ -1398,7 +1398,7 @@ function completeIterableValueWithPossibleStream(
  */
 function completeListItemValue(
   item: unknown,
-  acc: GraphQLResult<Array<unknown>>,
+  parent: GraphQLResult<Array<unknown>>,
   index: number,
   promises: Array<Promise<unknown>>,
   exeContext: ExecutionContext,
@@ -1409,6 +1409,7 @@ function completeListItemValue(
   incrementalContext: IncrementalContext | undefined,
   deferMap: ReadonlyMap<DeferUsage, DeferredFragmentRecord> | undefined,
 ): void {
+  const completedResults = parent[0];
   try {
     const completedItem = completeValue(
       exeContext,
@@ -1422,13 +1423,14 @@ function completeListItemValue(
     );
 
     if (isPromise(completedItem)) {
+      completedResults.push(undefined);
       // Note: we don't rely on a `catch` method, but we do expect "thenable"
       // to take a second callback for the error case.
       promises.push(
         completedItem.then(
           (resolved) => {
-            acc[0][index] = resolved[0];
-            appendNewIncrementalDataRecords(acc, resolved[1]);
+            completedResults[index] = resolved[0];
+            appendNewIncrementalDataRecords(parent, resolved[1]);
           },
           (rawError) => {
             handleFieldError(
@@ -1439,13 +1441,13 @@ function completeListItemValue(
               itemPath,
               incrementalContext,
             );
-            acc[0][index] = null;
+            completedResults[index] = null;
           },
         ),
       );
     } else {
-      acc[0][index] = completedItem[0];
-      appendNewIncrementalDataRecords(acc, completedItem[1]);
+      completedResults.push(completedItem[0]);
+      appendNewIncrementalDataRecords(parent, completedItem[1]);
     }
   } catch (rawError) {
     handleFieldError(
@@ -1456,13 +1458,13 @@ function completeListItemValue(
       itemPath,
       incrementalContext,
     );
-    acc[0].push(null);
+    completedResults.push(null);
   }
 }
 
 async function completePromisedListItemValue(
   item: unknown,
-  acc: GraphQLResult<Array<unknown>>,
+  parent: GraphQLResult<Array<unknown>>,
   index: number,
   exeContext: ExecutionContext,
   itemType: GraphQLOutputType,
@@ -1472,6 +1474,8 @@ async function completePromisedListItemValue(
   incrementalContext: IncrementalContext | undefined,
   deferMap: ReadonlyMap<DeferUsage, DeferredFragmentRecord> | undefined,
 ): Promise<void> {
+  const completedResults = parent[0];
+  completedResults[index] = undefined;
   try {
     const resolvedItem = await item;
     let completed = completeValue(
@@ -1487,8 +1491,8 @@ async function completePromisedListItemValue(
     if (isPromise(completed)) {
       completed = await completed;
     }
-    acc[0][index] = completed[0];
-    appendNewIncrementalDataRecords(acc, completed[1]);
+    completedResults[index] = completed[0];
+    appendNewIncrementalDataRecords(parent, completed[1]);
   } catch (rawError) {
     handleFieldError(
       rawError,
@@ -1498,7 +1502,7 @@ async function completePromisedListItemValue(
       itemPath,
       incrementalContext,
     );
-    acc[0][index] = null;
+    completedResults[index] = null;
   }
 }