Shake off dependency on itertools

Author: tomhoule

graphql_client/Cargo.toml

@@ -11,7 +11,6 @@ categories = ["network-programming", "web-programming", "wasm"]
 [dependencies]
 failure = "0.1"
 graphql_query_derive = {path = "../graphql_query_derive", version = "0.6.1" }
-itertools = "0.7"
 serde = "^1.0.78"
 serde_derive = "1.0"
 serde_json = "1.0"

graphql_client/src/lib.rs

@@ -5,7 +5,6 @@
 #![deny(warnings)]
 #![deny(missing_docs)]
 
-extern crate itertools;
 extern crate serde;
 #[macro_use]
 extern crate serde_derive;
@@ -20,8 +19,6 @@ pub use graphql_query_derive::*;
 use std::collections::HashMap;
 use std::fmt::{self, Display};
 
-use itertools::Itertools;
-
 /// A convenience trait that can be used to build a GraphQL request body.
 ///
 /// This will be implemented for you by codegen in the normal case. It is implemented on the struct you place the derive on.
@@ -208,7 +205,18 @@ impl Display for Error {
         let path = self
             .path
             .as_ref()
-            .map(|fragments| format!("{}", fragments.iter().format("/")))
+            .map(|fragments| {
+                format!(
+                    "{}",
+                    fragments
+                        .iter()
+                        .fold(String::new(), |mut acc, item| {
+                            acc.push_str(&format!("{}/", item));
+                            acc
+                        })
+                        .trim_end_matches("/")
+                )
+            })
             .unwrap_or_else(|| "<query>".to_string());
 
         // Get the location of the error. We'll use just the first location for this.

graphql_client/tests/json_schema/query_2.graphql

@@ -3,4 +3,3 @@ query WithSchema2 {
     accountId
   }
 }
-

graphql_client_codegen/Cargo.toml

@@ -8,7 +8,6 @@ repository = "https://github.com/graphql-rust/graphql-client"
 
 [dependencies]
 failure = "0.1"
-itertools = "0.7"
 lazy_static = "1.0"
 quote = "0.6"
 syn = "0.15.20"

graphql_client_codegen/src/inputs.rs

@@ -212,7 +212,7 @@ mod tests {
         };
 
         let expected: String = vec![
-            "# [ derive ( Serialize , Clone ) ] ",
+            "# [ derive ( Clone , Serialize ) ] ",
             "pub struct Cat { ",
             "pub offsprings : Vec < Cat > , ",
             "# [ serde ( rename = \"pawsCount\" ) ] ",

graphql_client_codegen/src/lib.rs

@@ -9,7 +9,6 @@
 extern crate failure;
 extern crate graphql_parser;
 extern crate heck;
-extern crate itertools;
 #[macro_use]
 extern crate lazy_static;
 extern crate proc_macro;

graphql_client_codegen/src/query.rs

@@ -1,7 +1,6 @@
 use deprecation::DeprecationStrategy;
 use failure;
 use fragments::GqlFragment;
-use itertools::Itertools;
 use proc_macro2::Span;
 use proc_macro2::TokenStream;
 use schema::Schema;
@@ -104,15 +103,19 @@ impl<'query, 'schema> QueryContext<'query, 'schema> {
     }
 
     pub(crate) fn variables_derives(&self) -> TokenStream {
-        let derives = self.variables_derives.iter().unique();
+        use std::collections::BTreeSet;
+        let derives: BTreeSet<&Ident> = self.variables_derives.iter().collect();
+        let derives = derives.iter();
 
         quote! {
             #[derive( #(#derives),* )]
         }
     }
 
     pub(crate) fn response_derives(&self) -> TokenStream {
-        let derives = self.response_derives.iter().unique();
+        use std::collections::BTreeSet;
+        let derives: BTreeSet<&Ident> = self.response_derives.iter().collect();
+        let derives = derives.iter();
 
         quote! {
             #[derive( #(#derives),* )]

graphql_client_codegen/src/shared.rs

@@ -1,7 +1,6 @@
 use deprecation::{DeprecationStatus, DeprecationStrategy};
 use failure;
 use heck::{CamelCase, SnakeCase};
-use itertools::Itertools;
 use objects::GqlObjectField;
 use proc_macro2::{Ident, Span, TokenStream};
 use query::QueryContext;
@@ -115,7 +114,12 @@ pub(crate) fn response_fields_for_selection(
                             schema_fields
                                 .iter()
                                 .map(|ref field| &field.name)
-                                .format("`, `"),
+                                .fold(String::new(), |mut acc, item| {
+                                    acc.push_str(item);
+                                    acc.push_str(", ");
+                                    acc
+                                })
+                                .trim_end_matches(", ")
                         )
                     })?;
                 let ty = schema_field.type_.to_rust(