flip unnecessary booleans (clippy::if_not_else)

Author: daniel.eades

graphql_client_cli/src/generate.rs

@@ -94,10 +94,10 @@ pub(crate) fn generate_code(params: CliCodegenParams) -> CliResult<()> {
         .map_err(|err| Error::message(format!("Error generating module code: {err}")))?;
 
     let generated_code = format!("{WARNING_SUPPRESSION}\n{gen}");
-    let generated_code = if !no_formatting {
-        format(&generated_code)?
-    } else {
+    let generated_code = if no_formatting {
         generated_code
+    } else {
+        format(&generated_code)?
     };
 
     let query_file_name: OsString =

graphql_client_codegen/src/codegen.rs

@@ -147,10 +147,10 @@ fn generate_variable_struct_field(
     let ident = Ident::new(&safe_name, Span::call_site());
     let rename_annotation = shared::field_rename_annotation(&variable.name, &safe_name);
     let skip_serializing_annotation = if *options.skip_serializing_none() {
-        if variable.r#type.qualifiers.first() != Some(&GraphqlTypeQualifier::Required) {
-            Some(quote!(#[serde(skip_serializing_if = "Option::is_none")]))
-        } else {
+        if variable.r#type.qualifiers.first() == Some(&GraphqlTypeQualifier::Required) {
             None
+        } else {
+            Some(quote!(#[serde(skip_serializing_if = "Option::is_none")]))
         }
     } else {
         None

graphql_client_codegen/src/codegen/selection.rs

@@ -592,7 +592,9 @@ impl<'a> ExpandedSelection<'a> {
                 continue;
             }
 
-            let (on_field, on_enum) = if !on_variants.is_empty() {
+            let (on_field, on_enum) = if on_variants.is_empty() {
+                (None, None)
+            } else {
                 let enum_name = Ident::new(&format!("{}On", ty.name), Span::call_site());
 
                 let on_field = quote!(#[serde(flatten)] pub on: #enum_name);
@@ -606,8 +608,6 @@ impl<'a> ExpandedSelection<'a> {
                 );
 
                 (Some(on_field), Some(on_enum))
-            } else {
-                (None, None)
             };
 
             let tokens = quote! {

graphql_client_codegen/src/codegen/shared.rs

@@ -24,10 +24,10 @@ pub(crate) fn keyword_replace<'a>(needle: impl Into<Cow<'a, str>>) -> Cow<'a, st
 /// the equivalent rust name, produces a serde annotation to map them during
 /// (de)serialization if it is necessary, otherwise an empty TokenStream.
 pub(crate) fn field_rename_annotation(graphql_name: &str, rust_name: &str) -> Option<TokenStream> {
-    if graphql_name != rust_name {
-        Some(quote!(#[serde(rename = #graphql_name)]))
-    } else {
+    if graphql_name == rust_name {
         None
+    } else {
+        Some(quote!(#[serde(rename = #graphql_name)]))
     }
 }