Simplify find_deprecated_usages since deprecation_reason is always present

Replicates graphql/graphql-js@62532a5

Author: Cito

src/graphql/utilities/find_deprecated_usages.py

@@ -32,31 +32,25 @@ def __init__(self, type_info: TypeInfo):
         self.errors = []
 
     def enter_field(self, node, *_args):
+        parent_type = self.type_info.get_parent_type()
         field_def = self.type_info.get_field_def()
-        if field_def and field_def.is_deprecated:
-            parent_type = self.type_info.get_parent_type()
-            if parent_type:
-                field_name = node.name.value
-                reason = field_def.deprecation_reason
-                self.errors.append(
-                    GraphQLError(
-                        f"The field '{parent_type.name}.{field_name}'"
-                        " is deprecated." + ("" if reason is None else f" {reason}"),
-                        node,
-                    )
+        if parent_type and field_def.deprecation_reason is not None:
+            self.errors.append(
+                GraphQLError(
+                    f"The field '{parent_type.name}.{node.name.value}'"
+                    " is deprecated. " + field_def.deprecation_reason,
+                    node,
                 )
+            )
 
     def enter_enum_value(self, node, *_args):
+        type_ = get_named_type(self.type_info.get_input_type())
         enum_val = self.type_info.get_enum_value()
-        if enum_val and enum_val.is_deprecated:
-            type_ = get_named_type(self.type_info.get_input_type())
-            if type_:
-                enum_val_name = node.value
-                reason = enum_val.deprecation_reason
-                self.errors.append(
-                    GraphQLError(
-                        f"The enum value '{type_.name}.{enum_val_name}'"
-                        " is deprecated." + (f" {reason}" if reason else ""),
-                        node,
-                    )
+        if type_ and enum_val and enum_val.deprecation_reason is not None:
+            self.errors.append(
+                GraphQLError(
+                    f"The enum value '{type_.name}.{node.value}'"
+                    " is deprecated. " + enum_val.deprecation_reason,
+                    node,
                 )
+            )

tests/utilities/test_find_deprecated_usages.py

@@ -7,8 +7,8 @@ def describe_find_deprecated_usages():
     schema = build_schema(
         """
         enum EnumType {
-          ONE
-          TWO @deprecated(reason: "Some enum reason.")
+          NORMAL_VALUE
+          DEPRECATED_VALUE @deprecated(reason: "Some enum reason.")
         }
 
         type Query {
@@ -19,7 +19,9 @@ def describe_find_deprecated_usages():
     )
 
     def should_report_empty_set_for_no_deprecated_usages():
-        errors = find_deprecated_usages(schema, parse("{ normalField(enumArg: ONE) }"))
+        errors = find_deprecated_usages(
+            schema, parse("{ normalField(enumArg: [NORMAL_VALUE]) }")
+        )
 
         assert errors == []
 
@@ -35,10 +37,20 @@ def should_report_usage_of_deprecated_fields():
         ]
 
     def should_report_usage_of_deprecated_enums():
-        errors = find_deprecated_usages(schema, parse("{ normalField(enumArg: TWO) }"))
+        errors = find_deprecated_usages(
+            schema,
+            parse(
+                """
+                {
+                  normalField(enumArg: [NORMAL_VALUE, DEPRECATED_VALUE])
+                }
+                """
+            ),
+        )
 
         error_messages = [err.message for err in errors]
 
         assert error_messages == [
-            "The enum value 'EnumType.TWO' is deprecated. Some enum reason."
+            "The enum value 'EnumType.DEPRECATED_VALUE' is deprecated."
+            " Some enum reason."
         ]