test_known_directives_rule: add tests for missing directive locations

Replicates graphql/graphql-js@f9bf263

Author: Cito

tests/validation/test_known_directives.py

@@ -64,15 +64,17 @@ def with_no_directives():
             """
         )
 
-    def with_known_directives():
+    def with_standard_directives():
         assert_valid(
             """
             {
-              dog @include(if: true) {
-                name
-              }
               human @skip(if: false) {
                 name
+                pets {
+                  ... on Dog @include(if: true) {
+                    name
+                  }
+                }
               }
             }
             """
@@ -82,102 +84,136 @@ def with_unknown_directive():
         assert_errors(
             """
             {
-              dog @unknown(directive: "value") {
+              human @unknown(directive: "value") {
                 name
               }
             }
             """,
-            [{"message": "Unknown directive '@unknown'.", "locations": [(3, 19)]}],
+            [{"message": "Unknown directive '@unknown'.", "locations": [(3, 21)]}],
         )
 
     def with_many_unknown_directives():
         assert_errors(
             """
             {
-              dog @unknown(directive: "value") {
-                name
-              }
-              human @unknown(directive: "value") {
+              __typename @unknown
+              human @unknown {
                 name
-                pets @unknown(directive: "value") {
+                pets @unknown {
                   name
                 }
               }
             }
             """,
             [
-                {"message": "Unknown directive '@unknown'.", "locations": [(3, 19)]},
-                {"message": "Unknown directive '@unknown'.", "locations": [(6, 21)]},
-                {"message": "Unknown directive '@unknown'.", "locations": [(8, 22)]},
+                {"message": "Unknown directive '@unknown'.", "locations": [(3, 26)]},
+                {"message": "Unknown directive '@unknown'.", "locations": [(4, 21)]},
+                {"message": "Unknown directive '@unknown'.", "locations": [(6, 22)]},
             ],
         )
 
     def with_well_placed_directives():
         assert_valid(
             """
-            query ($var: Boolean) @onQuery {
-              name @include(if: $var)
-              ...Frag @include(if: true)
-              skippedField @skip(if: true)
-              ...SkippedFrag @skip(if: true)
-
-              ... @skip(if: true) {
-                skippedField
+            query ($var: Boolean @onVariableDefinition) @onQuery {
+              human @onField {
+                ...Frag @onFragmentSpread
+                ... @onInlineFragment {
+                  name @onField
+                }
               }
             }
 
             mutation @onMutation {
-              someField
+              someField @onField
             }
 
             subscription @onSubscription {
-              someField
+              someField @onField
             }
 
-            fragment Frag on SomeType @onFragmentDefinition {
-              someField
-            }
-            """
-        )
-
-    def with_well_placed_variable_definition_directive():
-        assert_valid(
-            """
-            query Foo($var: Boolean @onVariableDefinition) {
-              name
+            fragment Frag on Human @onFragmentDefinition {
+              name @onField
             }
             """
         )
 
     def with_misplaced_directives():
         assert_errors(
             """
-            query Foo($var: Boolean) @include(if: true) {
-              name @onQuery @include(if: $var)
-              ...Frag @onQuery
+            query ($var: Boolean @onQuery) @onMutation {
+              human @onQuery {
+                ...Frag @onQuery
+                ... @onQuery {
+                  name @onQuery
+                }
+              }
             }
 
-            mutation Bar @onQuery {
-              someField
+            mutation @onQuery {
+              someField @onQuery
+            }
+
+            subscription @onQuery {
+              someField @onQuery
+            }
+
+            fragment Frag on Human @onQuery {
+              name @onQuery
             }
             """,
             [
                 {
-                    "message": "Directive '@include' may not be used on query.",
-                    "locations": [(2, 38)],
+                    "message": "Directive '@onQuery'"
+                    " may not be used on variable definition.",
+                    "locations": [(2, 34)],
+                },
+                {
+                    "message": "Directive '@onMutation' may not be used on query.",
+                    "locations": [(2, 44)],
                 },
                 {
                     "message": "Directive '@onQuery' may not be used on field.",
-                    "locations": [(3, 20)],
+                    "locations": [(3, 21)],
                 },
                 {
                     "message": "Directive '@onQuery'"
                     " may not be used on fragment spread.",
-                    "locations": [(4, 23)],
+                    "locations": [(4, 25)],
+                },
+                {
+                    "message": "Directive '@onQuery'"
+                    " may not be used on inline fragment.",
+                    "locations": [(5, 21)],
+                },
+                {
+                    "message": "Directive '@onQuery' may not be used on field.",
+                    "locations": [(6, 24)],
                 },
                 {
                     "message": "Directive '@onQuery' may not be used on mutation.",
-                    "locations": [(7, 26)],
+                    "locations": [(11, 22)],
+                },
+                {
+                    "message": "Directive '@onQuery' may not be used on field.",
+                    "locations": [(12, 25)],
+                },
+                {
+                    "message": "Directive '@onQuery' may not be used on subscription.",
+                    "locations": [(15, 26)],
+                },
+                {
+                    "message": "Directive '@onQuery' may not be used on field.",
+                    "locations": [(16, 25)],
+                },
+                {
+                    "message": "Directive '@onQuery'"
+                    " may not be used on fragment definition.",
+                    "locations": [(19, 36)],
+                },
+                {
+                    "message": "Directive '@onQuery' may not be used on field.",
+                    "locations": [(20, 20)],
                 },
             ],
         )