Change check for source argument

Replicates graphql/graphql-js@ef0f1ab

Also removes check for name argument to be consistent here.

Author: Cito

src/graphql/language/parser.py

@@ -57,10 +57,9 @@
 from .directive_locations import DirectiveLocation
 from .ast import Token
 from .lexer import Lexer, is_punctuator_token_kind
-from .source import Source
+from .source import Source, is_source
 from .token_kind import TokenKind
 from ..error import GraphQLError, GraphQLSyntaxError
-from ..pyutils import inspect
 
 __all__ = ["parse", "parse_type", "parse_value"]
 
@@ -178,10 +177,10 @@ def __init__(
         no_location: bool = False,
         experimental_fragment_variables: bool = False,
     ):
-        if isinstance(source, str):
-            source = Source(source)
-        elif not isinstance(source, Source):
-            raise TypeError(f"Must provide Source. Received: {inspect(source)}.")
+        source = (
+            cast(Source, source) if is_source(source) else Source(cast(str, source))
+        )
+
         self._lexer = Lexer(source)
         self._no_location = no_location
         self._experimental_fragment_variables = experimental_fragment_variables

src/graphql/language/source.py

@@ -2,7 +2,7 @@
 
 from .location import SourceLocation
 
-__all__ = ["Source"]
+__all__ = ["Source", "is_source"]
 
 
 class Source:
@@ -26,11 +26,7 @@ def __init__(
 
         The ``line`` and ``column`` attributes in ``location_offset`` are 1-indexed.
         """
-        if not isinstance(body, str):
-            raise TypeError("body must be a string.")
         self.body = body
-        if not isinstance(name, str):
-            raise TypeError("name must be a string.")
         self.name = name
         if not isinstance(location_offset, SourceLocation):
             location_offset = SourceLocation._make(location_offset)
@@ -64,3 +60,11 @@ def __eq__(self, other: Any) -> bool:
 
     def __ne__(self, other: Any) -> bool:
         return not self == other
+
+
+def is_source(source: Any) -> bool:
+    """Test if the given value is a Source object.
+
+    For internal use only.
+    """
+    return isinstance(source, Source)

src/graphql/utilities/strip_ignored_characters.py

@@ -1,12 +1,12 @@
-from typing import Union
+from typing import Union, cast
 
-from ..language import Lexer, Source, TokenKind
+from ..language import Lexer, TokenKind
+from ..language.source import Source, is_source
 from ..language.block_string import (
     dedent_block_string_value,
     get_block_string_indentation,
 )
 from ..language.lexer import is_punctuator_token_kind
-from ..pyutils import inspect
 
 
 def strip_ignored_characters(source: Union[str, Source]) -> str:
@@ -65,14 +65,10 @@ def strip_ignored_characters(source: Union[str, Source]) -> str:
 
         """Type description""" type Foo{"""Field description""" bar:String}
     '''
-    source_obj = Source(source) if isinstance(source, str) else source
-    if not isinstance(source_obj, Source):
-        raise TypeError(
-            f"Must provide string or Source. Received: {inspect(source_obj)}."
-        )
-
-    body = source_obj.body
-    lexer = Lexer(source_obj)
+    source = cast(Source, source) if is_source(source) else Source(cast(str, source))
+
+    body = source.body
+    lexer = Lexer(source)
     stripped_body = ""
     was_last_added_token_non_punctuator = False
     while lexer.advance().kind != TokenKind.EOF:

tests/execution/test_sync.py

@@ -138,13 +138,6 @@ def does_not_return_an_awaitable_for_validation_errors():
             result = graphql_sync(schema, doc)
             assert result == (None, validation_errors)
 
-        def raises_a_type_error_when_no_query_is_passed():
-            with raises(TypeError) as exc_info:
-                # noinspection PyTypeChecker
-                assert graphql_sync(schema, None)  # type: ignore
-            msg = str(exc_info.value)
-            assert msg == "Must provide Source. Received: None."
-
         def does_not_return_an_awaitable_for_sync_execution():
             doc = "query Example { syncField }"
             assert graphql_sync(schema, doc, "rootValue") == (

tests/language/test_parser.py

@@ -45,24 +45,6 @@ def assert_syntax_error(text: str, message: str, location: Location) -> None:
 
 
 def describe_parser():
-    def asserts_that_a_source_to_parse_was_provided():
-        with raises(TypeError) as exc_info:
-            # noinspection PyArgumentList
-            assert parse()  # type: ignore
-        msg = str(exc_info.value)
-        assert "missing" in msg
-        assert "source" in msg
-        with raises(TypeError) as exc_info:
-            # noinspection PyTypeChecker
-            assert parse(None)  # type: ignore
-        msg = str(exc_info.value)
-        assert "Must provide Source. Received: None." in msg
-        with raises(TypeError) as exc_info:
-            # noinspection PyTypeChecker
-            assert parse({})  # type: ignore
-        msg = str(exc_info.value)
-        assert "Must provide Source. Received: {}." in msg
-
     def parse_provides_useful_errors():
         with raises(GraphQLSyntaxError) as exc_info:
             parse("{")

tests/language/test_source.py

@@ -78,20 +78,6 @@ def can_create_custom_attribute():
         node.custom = "bar"  # type: ignore
         assert node.custom == "bar"  # type: ignore
 
-    def rejects_invalid_body_and_name():
-        with raises(TypeError, match="body must be a string\\."):
-            # noinspection PyTypeChecker
-            Source(None)  # type: ignore
-        with raises(TypeError, match="body must be a string\\."):
-            # noinspection PyTypeChecker
-            Source(1)  # type: ignore
-        with raises(TypeError, match="name must be a string\\."):
-            # noinspection PyTypeChecker
-            Source("", None)  # type: ignore
-        with raises(TypeError, match="name must be a string\\."):
-            # noinspection PyTypeChecker
-            Source("", 1)  # type: ignore
-
     def rejects_invalid_location_offset():
         def create_source(location_offset: Tuple[int, int]) -> Source:
             return Source("", "", cast(SourceLocation, location_offset))

tests/utilities/test_strip_ignored_characters.py

@@ -75,23 +75,6 @@ def to_stay_the_same(self):
 
 
 def describe_strip_ignored_characters():
-    def asserts_that_a_source_was_provided():
-        with raises(
-            TypeError, match="missing 1 required positional argument: 'source'"
-        ):
-            # noinspection PyArgumentList
-            strip_ignored_characters()  # type: ignore
-        with raises(
-            TypeError, match="Must provide string or Source. Received: None\\."
-        ):
-            # noinspection PyTypeChecker
-            strip_ignored_characters(None)  # type: ignore
-
-    def asserts_that_a_valid_source_was_provided():
-        with raises(TypeError, match="Must provide string or Source. Received: {}\\."):
-            # noinspection PyTypeChecker
-            strip_ignored_characters({})  # type: ignore
-
     def strips_ignored_characters_from_graphql_query_document():
         query = dedent(
             """