Merge schema validation tests with other schema tests

Replicates graphql/graphql-js@8d7a5fd

Author: Cito

tests/type/test_definition.py

@@ -857,64 +857,3 @@ def rejects_a_non_type_as_nullable_type_of_non_null(type_):
             if isinstance(type_, GraphQLNonNull)
             else f"Can only create a wrapper for a GraphQLType, but got: {type_}."
         )
-
-
-def describe_type_system_a_schema_must_contain_uniquely_named_types():
-    def rejects_a_schema_which_redefines_a_built_in_type():
-        FakeString = GraphQLScalarType("String", serialize=lambda: None)
-
-        QueryType = GraphQLObjectType(
-            "Query",
-            {"normal": GraphQLField(GraphQLString), "fake": GraphQLField(FakeString)},
-        )
-
-        with raises(TypeError) as exc_info:
-            GraphQLSchema(QueryType)
-        msg = str(exc_info.value)
-        assert msg == (
-            "Schema must contain unique named types"
-            f" but contains multiple types named 'String'."
-        )
-
-    def rejects_a_schema_which_defines_an_object_twice():
-        A = GraphQLObjectType("SameName", {"f": GraphQLField(GraphQLString)})
-        B = GraphQLObjectType("SameName", {"f": GraphQLField(GraphQLString)})
-
-        QueryType = GraphQLObjectType("Query", {"a": A, "b": B})
-
-        with raises(TypeError) as exc_info:
-            GraphQLSchema(QueryType)
-        msg = str(exc_info.value)
-        assert msg == (
-            "Schema must contain unique named types"
-            f" but contains multiple types named 'SameName'."
-        )
-
-    def rejects_a_schema_with_same_named_objects_implementing_an_interface():
-        AnotherInterface = GraphQLInterfaceType(
-            "AnotherInterface", {"f": GraphQLField(GraphQLString)}
-        )
-
-        FirstBadObject = GraphQLObjectType(
-            "BadObject",
-            {"f": GraphQLField(GraphQLString)},
-            interfaces=[AnotherInterface],
-        )
-
-        SecondBadObject = GraphQLObjectType(
-            "BadObject",
-            {"f": GraphQLField(GraphQLString)},
-            interfaces=[AnotherInterface],
-        )
-
-        QueryType = GraphQLObjectType(
-            "Query", {"iface": GraphQLField(AnotherInterface)}
-        )
-
-        with raises(TypeError) as exc_info:
-            GraphQLSchema(QueryType, types=[FirstBadObject, SecondBadObject])
-        msg = str(exc_info.value)
-        assert msg == (
-            "Schema must contain unique named types"
-            f" but contains multiple types named 'BadObject'."
-        )

tests/type/test_schema.py

@@ -5,6 +5,7 @@
     GraphQLField,
     GraphQLInterfaceType,
     GraphQLObjectType,
+    GraphQLScalarType,
     GraphQLSchema,
     GraphQLString,
     GraphQLInputObjectType,
@@ -64,6 +65,58 @@ def checks_the_configuration_for_mistakes():
                 with raises(Exception):
                     GraphQLSchema(directives={})
 
+    def describe_a_schema_must_contain_uniquely_named_types():
+        def rejects_a_schema_which_redefines_a_built_in_type():
+            FakeString = GraphQLScalarType("String", serialize=lambda: None)
+
+            QueryType = GraphQLObjectType(
+                "Query",
+                {
+                    "normal": GraphQLField(GraphQLString),
+                    "fake": GraphQLField(FakeString),
+                },
+            )
+
+            with raises(TypeError) as exc_info:
+                GraphQLSchema(QueryType)
+            msg = str(exc_info.value)
+            assert msg == (
+                "Schema must contain unique named types"
+                f" but contains multiple types named 'String'."
+            )
+
+        def rejects_a_schema_which_defines_an_object_twice():
+            types = [
+                GraphQLObjectType("SameName", {}),
+                GraphQLObjectType("SameName", {}),
+            ]
+
+            with raises(TypeError) as exc_info:
+                GraphQLSchema(types=types)
+            msg = str(exc_info.value)
+            assert msg == (
+                "Schema must contain unique named types"
+                f" but contains multiple types named 'SameName'."
+            )
+
+        def rejects_a_schema_which_defines_fields_with_conflicting_types():
+            fields = {}
+            QueryType = GraphQLObjectType(
+                "Query",
+                {
+                    "a": GraphQLField(GraphQLObjectType("SameName", fields)),
+                    "b": GraphQLField(GraphQLObjectType("SameName", fields)),
+                },
+            )
+
+            with raises(TypeError) as exc_info:
+                GraphQLSchema(QueryType)
+            msg = str(exc_info.value)
+            assert msg == (
+                "Schema must contain unique named types"
+                f" but contains multiple types named 'SameName'."
+            )
+
         def describe_when_assumed_valid():
             def configures_the_schema_to_have_no_errors():
                 # noinspection PyProtectedMember