Make 'extensions' non-optional in schema types

Replicates graphql/graphql-js@ec57f06

Author: Cito

src/graphql/type/definition.py

@@ -196,7 +196,7 @@ class GraphQLNamedType(GraphQLType):
 
     name: str
     description: Optional[str]
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[TypeDefinitionNode]
     extension_ast_nodes: FrozenList[TypeExtensionNode]
 
@@ -214,9 +214,10 @@ def __init__(
             raise TypeError("The name must be a string.")
         if description is not None and not is_description(description):
             raise TypeError("The description must be a string.")
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError(f"{name} extensions must be a dictionary with string keys.")
         if ast_node and not isinstance(ast_node, TypeDefinitionNode):
@@ -435,7 +436,7 @@ class GraphQLField:
     subscribe: Optional["GraphQLFieldResolver"]
     description: Optional[str]
     deprecation_reason: Optional[str]
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[FieldDefinitionNode]
 
     def __init__(
@@ -478,9 +479,10 @@ def __init__(
             raise TypeError("The description must be a string.")
         if deprecation_reason is not None and not is_description(deprecation_reason):
             raise TypeError("The deprecation reason must be a string.")
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError("Field extensions must be a dictionary with string keys.")
         if ast_node and not isinstance(ast_node, FieldDefinitionNode):
@@ -581,7 +583,7 @@ class GraphQLArgument:
     description: Optional[str]
     deprecation_reason: Optional[str]
     out_name: Optional[str]  # for transforming names (extension of GraphQL.js)
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[InputValueDefinitionNode]
 
     def __init__(
@@ -602,9 +604,10 @@ def __init__(
             raise TypeError("Argument deprecation reason must be a string.")
         if out_name is not None and not isinstance(out_name, str):
             raise TypeError("Argument out name must be a string.")
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError(
                 "Argument extensions must be a dictionary with string keys."
@@ -1187,7 +1190,7 @@ class GraphQLEnumValue:
     value: Any
     description: Optional[str]
     deprecation_reason: Optional[str]
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[EnumValueDefinitionNode]
 
     def __init__(
@@ -1204,9 +1207,10 @@ def __init__(
             raise TypeError(
                 "The deprecation reason for the enum value must be a string."
             )
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError(
                 "Enum value extensions must be a dictionary with string keys."
@@ -1376,7 +1380,7 @@ class GraphQLInputField:
     description: Optional[str]
     deprecation_reason: Optional[str]
     out_name: Optional[str]  # for transforming names (extension of GraphQL.js)
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[InputValueDefinitionNode]
 
     def __init__(
@@ -1397,9 +1401,10 @@ def __init__(
             raise TypeError("Input field deprecation reason must be a string.")
         if out_name is not None and not isinstance(out_name, str):
             raise TypeError("Input field out name must be a string.")
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError(
                 "Input field extensions must be a dictionary with string keys."

src/graphql/type/directives.py

@@ -32,7 +32,7 @@ class GraphQLDirective:
     is_repeatable: bool
     args: Dict[str, GraphQLArgument]
     description: Optional[str]
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[ast.DirectiveDefinitionNode]
 
     def __init__(
@@ -87,9 +87,10 @@ def __init__(
             raise TypeError(f"{name} AST node must be a DirectiveDefinitionNode.")
         if description is not None and not is_description(description):
             raise TypeError(f"{name} description must be a string.")
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError(f"{name} extensions must be a dictionary with string keys.")
         self.name = name

src/graphql/type/schema.py

@@ -98,7 +98,7 @@ class GraphQLSchema:
     type_map: TypeMap
     directives: FrozenList[GraphQLDirective]
     description: Optional[str]
-    extensions: Optional[Dict[str, Any]]
+    extensions: Dict[str, Any]
     ast_node: Optional[ast.SchemaDefinitionNode]
     extension_ast_nodes: FrozenList[ast.SchemaExtensionNode]
 
@@ -151,9 +151,10 @@ def __init__(
                 directives = FrozenList(directives)
         if description is not None and not is_description(description):
             raise TypeError("Schema description must be a string.")
-        if extensions is not None and (
-            not isinstance(extensions, dict)
-            or not all(isinstance(key, str) for key in extensions)
+        if extensions is None:
+            extensions = {}
+        elif not isinstance(extensions, dict) or not all(
+            isinstance(key, str) for key in extensions
         ):
             raise TypeError("Schema extensions must be a dictionary with string keys.")
         if ast_node and not isinstance(ast_node, ast.SchemaDefinitionNode):

src/graphql/utilities/build_ast_schema.py

@@ -46,7 +46,7 @@ def build_ast_schema(
         description=None,
         types=[],
         directives=[],
-        extensions=None,
+        extensions={},
         ast_node=None,
         extension_ast_nodes=[],
         assume_valid=False,

src/graphql/utilities/extend_schema.py

@@ -662,7 +662,7 @@ def build_type(ast_node: TypeDefinitionNode) -> GraphQLNamedType:
         "description": schema_def.description.value
         if schema_def and schema_def.description
         else None,
-        "extensions": None,
+        "extensions": {},
         "ast_node": schema_def or schema_kwargs["ast_node"],
         "extension_ast_nodes": schema_kwargs["extension_ast_nodes"] + schema_extensions,
         "assume_valid": assume_valid,

tests/type/test_definition.py

@@ -73,7 +73,7 @@ def defines_a_scalar_type():
             "serialize": None,
             "parse_value": None,
             "parse_literal": None,
-            "extensions": None,
+            "extensions": {},
             "ast_node": None,
             "extension_ast_nodes": [],
         }
@@ -274,7 +274,7 @@ def defines_a_field():
             "subscribe": None,
             "description": None,
             "deprecation_reason": None,
-            "extensions": None,
+            "extensions": {},
             "ast_node": None,
         }
 
@@ -421,7 +421,7 @@ def accepts_an_object_type_with_a_field_function():
         assert field.resolve is None
         assert field.subscribe is None
         assert field.deprecation_reason is None
-        assert field.extensions is None
+        assert field.extensions == {}
         assert field.ast_node is None
 
     def thunk_for_fields_of_object_type_is_resolved_only_once():
@@ -455,12 +455,12 @@ def accepts_an_object_type_with_field_args():
         assert arg.type is ScalarType
         assert arg.default_value is Undefined
         assert arg.deprecation_reason is None
-        assert arg.extensions is None
+        assert arg.extensions == {}
         assert arg.ast_node is None
         assert field.resolve is None
         assert field.subscribe is None
         assert field.deprecation_reason is None
-        assert field.extensions is None
+        assert field.extensions == {}
         assert field.ast_node is None
 
     def accepts_an_object_type_with_list_interfaces():
@@ -687,15 +687,15 @@ def defines_an_interface_type():
         assert interface.fields == fields
         assert interface.fields is not fields
         assert interface.resolve_type is None
-        assert interface.extensions is None
+        assert interface.extensions == {}
         kwargs = interface.to_kwargs()
         assert kwargs == {
             "name": "AnotherInterface",
             "description": None,
             "fields": fields,
             "interfaces": [],
             "resolve_type": None,
-            "extensions": None,
+            "extensions": {},
             "ast_node": None,
             "extension_ast_nodes": [],
         }
@@ -1040,7 +1040,7 @@ def defines_an_enum_type_with_deprecated_value():
         assert deprecated_value == GraphQLEnumValue(deprecation_reason="Just because")
         assert deprecated_value.deprecation_reason == "Just because"
         assert deprecated_value.value is None
-        assert deprecated_value.extensions is None
+        assert deprecated_value.extensions == {}
         assert deprecated_value.ast_node is None
 
     def defines_an_enum_type_with_a_value_of_none_and_invalid():
@@ -1058,19 +1058,19 @@ def defines_an_enum_type_with_a_value_of_none_and_invalid():
         assert null_value.description is None
         assert null_value.value is None
         assert null_value.deprecation_reason is None
-        assert null_value.extensions is None
+        assert null_value.extensions == {}
         assert null_value.ast_node is None
         null_value = EnumTypeWithNullishValue.values["NAN"]
         assert null_value.description is None
         assert isnan(null_value.value)
         assert null_value.deprecation_reason is None
-        assert null_value.extensions is None
+        assert null_value.extensions == {}
         assert null_value.ast_node is None
         no_custom_value = EnumTypeWithNullishValue.values["NO_CUSTOM_VALUE"]
         assert no_custom_value.description is None
         assert no_custom_value.value is Undefined
         assert no_custom_value.deprecation_reason is None
-        assert no_custom_value.extensions is None
+        assert no_custom_value.extensions == {}
         assert no_custom_value.ast_node is None
 
     def accepts_a_well_defined_enum_type_with_empty_value_definition():
@@ -1444,7 +1444,7 @@ def accepts_an_input_object_type_with_fields():
             assert input_field.type is ScalarType
             assert input_field.default_value is Undefined
             assert input_field.deprecation_reason is None
-            assert input_field.extensions is None
+            assert input_field.extensions == {}
             assert input_field.ast_node is None
             assert input_field.out_name is None
 
@@ -1468,7 +1468,7 @@ def accepts_an_input_object_type_with_a_field_function():
             assert input_field.type is ScalarType
             assert input_field.default_value is Undefined
             assert input_field.deprecation_reason is None
-            assert input_field.extensions is None
+            assert input_field.extensions == {}
             assert input_field.ast_node is None
             assert input_field.out_name is None
 

tests/type/test_directives.py

@@ -22,7 +22,7 @@ def can_create_instance():
         assert directive.args == {"arg": arg}
         assert directive.is_repeatable is True
         assert directive.description == "test description"
-        assert directive.extensions is None
+        assert directive.extensions == {}
         assert directive.ast_node is node
 
     def defines_a_directive_with_no_args():
@@ -32,7 +32,7 @@ def defines_a_directive_with_no_args():
         assert directive.name == "Foo"
         assert directive.args == {}
         assert directive.is_repeatable is False
-        assert directive.extensions is None
+        assert directive.extensions == {}
         assert directive.locations == locations
 
     def defines_a_directive_with_multiple_args():