OverlappingFieldsCanBeMerged: arguments always have value

Replicates graphql/graphql-js@00495a2

Author: Cito

src/graphql/validation/rules/overlapping_fields_can_be_merged.py

@@ -9,6 +9,7 @@
     FragmentSpreadNode,
     InlineFragmentNode,
     SelectionSetNode,
+    ValueNode,
     print_ast,
 )
 from ...type import (
@@ -598,8 +599,8 @@ def same_arguments(
     return True
 
 
-def same_value(value1, value2):
-    return (not value1 and not value2) or (print_ast(value1) == print_ast(value2))
+def same_value(value1: ValueNode, value2: ValueNode) -> bool:
+    return print_ast(value1) == print_ast(value2)
 
 
 def do_types_conflict(type1: GraphQLOutputType, type2: GraphQLOutputType) -> bool:

tests/validation/test_overlapping_fields_can_be_merged.py

@@ -10,10 +10,6 @@
 assert_valid = partial(assert_errors, errors=[])
 
 
-def assert_valid_with_schema(schema, query_str):
-    assert_errors(query_str, [], schema)
-
-
 def describe_validate_overlapping_fields_can_be_merged():
     def unique_fields():
         assert_valid(