Move is_input/output_type to rest of predicates test

Replicates graphql/graphql-js@d48e481

Author: Cito

tests/type/test_definition.py

@@ -22,9 +22,7 @@
     GraphQLOutputType,
     GraphQLInputField,
     GraphQLNonNull,
-    is_input_type,
     is_object_type,
-    is_output_type,
 )
 
 
@@ -276,36 +274,6 @@ def stringifies_simple_types():
         assert str(GraphQLList(GraphQLNonNull(GraphQLInt))) == "[Int!]"
         assert str(GraphQLList(GraphQLList(GraphQLInt))) == "[[Int]]"
 
-    def identifies_input_types():
-        expected = (
-            (GraphQLInt, True),
-            (ObjectType, False),
-            (InterfaceType, False),
-            (UnionType, False),
-            (EnumType, True),
-            (InputObjectType, True),
-        )
-
-        for type_, answer in expected:
-            assert is_input_type(type_) is answer
-            assert is_input_type(GraphQLList(type_)) is answer
-            assert is_input_type(GraphQLNonNull(type_)) is answer
-
-    def identifies_output_types():
-        expected = (
-            (GraphQLInt, True),
-            (ObjectType, True),
-            (InterfaceType, True),
-            (UnionType, True),
-            (EnumType, True),
-            (InputObjectType, False),
-        )
-
-        for type_, answer in expected:
-            assert is_output_type(type_) is answer
-            assert is_output_type(GraphQLList(type_)) is answer
-            assert is_output_type(GraphQLNonNull(type_)) is answer
-
     def prohibits_nesting_nonnull_inside_nonnull():
         with raises(TypeError) as exc_info:
             # noinspection PyTypeChecker

tests/type/test_predicate.py

@@ -204,52 +204,79 @@ def returns_false_for_a_not_non_null_wrapped_type():
                 assert_non_null_type(GraphQLList(GraphQLNonNull(ObjectType)))
 
     def describe_is_input_type():
+        def _assert_input_type(type_):
+            assert is_input_type(type_) is True
+            assert_input_type(type_)
+
         def returns_true_for_an_input_type():
-            assert is_input_type(InputObjectType) is True
-            assert_input_type(InputObjectType)
+            _assert_input_type(GraphQLString)
+            _assert_input_type(EnumType)
+            _assert_input_type(InputObjectType)
 
         def returns_true_for_a_wrapped_input_type():
-            assert is_input_type(GraphQLList(InputObjectType)) is True
-            assert_input_type(GraphQLList(InputObjectType))
-            assert is_input_type(GraphQLNonNull(InputObjectType)) is True
-            assert_input_type(GraphQLNonNull(InputObjectType))
+            _assert_input_type(GraphQLList(GraphQLString))
+            _assert_input_type(GraphQLList(EnumType))
+            _assert_input_type(GraphQLList(InputObjectType))
 
-        def returns_false_for_an_output_type():
-            assert is_input_type(ObjectType) is False
+            _assert_input_type(GraphQLNonNull(GraphQLString))
+            _assert_input_type(GraphQLNonNull(EnumType))
+            _assert_input_type(GraphQLNonNull(InputObjectType))
+
+        def _assert_non_input_type(type_):
+            assert is_input_type(type_) is False
             with raises(TypeError):
-                assert_input_type(ObjectType)
+                assert_input_type(type_)
+
+        def returns_false_for_an_output_type():
+            _assert_non_input_type(ObjectType)
+            _assert_non_input_type(InterfaceType)
+            _assert_non_input_type(UnionType)
 
         def returns_false_for_a_wrapped_output_type():
-            assert is_input_type(GraphQLList(ObjectType)) is False
-            with raises(TypeError):
-                assert_input_type(GraphQLList(ObjectType))
-            assert is_input_type(GraphQLNonNull(ObjectType)) is False
-            with raises(TypeError):
-                assert_input_type(GraphQLNonNull(ObjectType))
+            _assert_non_input_type(GraphQLList(ObjectType))
+            _assert_non_input_type(GraphQLList(InterfaceType))
+            _assert_non_input_type(GraphQLList(UnionType))
+
+            _assert_non_input_type(GraphQLNonNull(ObjectType))
+            _assert_non_input_type(GraphQLNonNull(InterfaceType))
+            _assert_non_input_type(GraphQLNonNull(UnionType))
 
     def describe_is_output_type():
+        def _assert_output_type(type_):
+            assert is_output_type(type_) is True
+            assert_output_type(type_)
+
         def returns_true_for_an_output_type():
-            assert is_output_type(ObjectType) is True
-            assert_output_type(ObjectType)
+            _assert_output_type(GraphQLString)
+            _assert_output_type(ObjectType)
+            _assert_output_type(InterfaceType)
+            _assert_output_type(UnionType)
+            _assert_output_type(EnumType)
 
         def returns_true_for_a_wrapped_output_type():
-            assert is_output_type(GraphQLList(ObjectType)) is True
-            assert_output_type(GraphQLList(ObjectType))
-            assert is_output_type(GraphQLNonNull(ObjectType)) is True
-            assert_output_type(GraphQLNonNull(ObjectType))
+            _assert_output_type(GraphQLList(GraphQLString))
+            _assert_output_type(GraphQLList(ObjectType))
+            _assert_output_type(GraphQLList(InterfaceType))
+            _assert_output_type(GraphQLList(UnionType))
+            _assert_output_type(GraphQLList(EnumType))
 
-        def returns_false_for_an_input_type():
-            assert is_output_type(InputObjectType) is False
+            _assert_output_type(GraphQLNonNull(GraphQLString))
+            _assert_output_type(GraphQLNonNull(ObjectType))
+            _assert_output_type(GraphQLNonNull(InterfaceType))
+            _assert_output_type(GraphQLNonNull(UnionType))
+            _assert_output_type(GraphQLNonNull(EnumType))
+
+        def _assert_non_output_type(type_):
+            assert is_output_type(type_) is False
             with raises(TypeError):
-                assert_output_type(InputObjectType)
+                assert_output_type(type_)
+
+        def returns_false_for_an_input_type():
+            _assert_non_output_type(InputObjectType)
 
         def returns_false_for_a_wrapped_input_type():
-            assert is_output_type(GraphQLList(InputObjectType)) is False
-            with raises(TypeError):
-                assert_output_type(GraphQLList(InputObjectType))
-            assert is_output_type(GraphQLNonNull(InputObjectType)) is False
-            with raises(TypeError):
-                assert_output_type(GraphQLNonNull(InputObjectType))
+            _assert_non_output_type(GraphQLList(InputObjectType))
+            _assert_non_output_type(GraphQLNonNull(InputObjectType))
 
     def describe_is_leaf_type():
         def returns_true_for_scalar_and_enum_types():