Make more lists read only and add ReadOnlyDict

Author: Cito

README.md

@@ -13,7 +13,7 @@ a query language for APIs created by Facebook.
 [![Code Style](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
 
 The current version 1.0.4 of GraphQL-core-next is up-to-date with GraphQL.js version
-14.3.0. All parts of the API are covered by an extensive test suite of currently 1776
+14.3.0. All parts of the API are covered by an extensive test suite of currently 1778
 unit tests.
 
 

graphql/pyutils/__init__.py

@@ -21,7 +21,9 @@
 from .or_list import or_list
 from .quoted_or_list import quoted_or_list
 from .suggestion_list import suggestion_list
-from .read_only_list import ReadOnlyError, ReadOnlyList
+from .read_only_error import ReadOnlyError
+from .read_only_list import ReadOnlyList
+from .read_only_dict import ReadOnlyDict
 
 __all__ = [
     "camel_to_snake",
@@ -41,4 +43,5 @@
     "suggestion_list",
     "ReadOnlyError",
     "ReadOnlyList",
+    "ReadOnlyDict",
 ]

graphql/pyutils/read_only_dict.py

@@ -0,0 +1,35 @@
+__all__ = ["ReadOnlyDict"]
+
+from .read_only_error import ReadOnlyError
+
+
+class ReadOnlyDict(dict):
+    """Dictionary that can only be read, but not changed."""
+
+    def __delitem__(self, key):
+        raise ReadOnlyError
+
+    def __setitem__(self, key, value):
+        raise ReadOnlyError
+
+    def __add__(self, value):
+        return dict.__add__(self, value)
+
+    def __iadd__(self, value):
+        raise ReadOnlyError
+
+    def clear(self):
+        raise ReadOnlyError
+
+    def pop(self, key, default=None):
+        raise ReadOnlyError
+
+    def popitem(self):
+        raise ReadOnlyError
+
+    def setdefault(self, key, default=None):
+        raise ReadOnlyError
+
+    def update(self, other=None):
+        raise ReadOnlyError
+

graphql/pyutils/read_only_error.py

@@ -0,0 +1,5 @@
+__all__ = ["ReadOnlyError"]
+
+
+class ReadOnlyError(TypeError):
+    """Error when trying to write to a read only collection."""

graphql/pyutils/read_only_list.py

@@ -1,8 +1,6 @@
-__all__ = ["ReadOnlyError", "ReadOnlyList"]
+__all__ = ["ReadOnlyList"]
 
-
-class ReadOnlyError(TypeError):
-    """Error when trying to write to a ReadOnlyList."""
+from .read_only_error import ReadOnlyError
 
 
 class ReadOnlyList(list):

graphql/type/introspection.py

@@ -21,7 +21,7 @@
     is_union_type,
 )
 from ..language import DirectiveLocation, print_ast
-from ..pyutils import inspect
+from ..pyutils import inspect, ReadOnlyDict
 from .scalars import GraphQLBoolean, GraphQLString
 
 __all__ = [
@@ -492,7 +492,7 @@ class TypeKind(Enum):
 
 # Since double underscore names are subject to name mangling in Python,
 # the introspection classes are best imported via this dictionary:
-introspection_types = {
+introspection_types = ReadOnlyDict({
     "__Schema": __Schema,
     "__Directive": __Directive,
     "__DirectiveLocation": __DirectiveLocation,
@@ -501,7 +501,7 @@ class TypeKind(Enum):
     "__InputValue": __InputValue,
     "__EnumValue": __EnumValue,
     "__TypeKind": __TypeKind,
-}
+})
 
 
 def is_introspection_type(type_: Any) -> bool:

graphql/type/scalars.py

@@ -2,7 +2,7 @@
 from typing import Any
 
 from ..error import INVALID
-from ..pyutils import inspect, is_finite, is_integer
+from ..pyutils import inspect, is_finite, is_integer, ReadOnlyDict
 from ..language.ast import (
     BooleanValueNode,
     FloatValueNode,
@@ -241,10 +241,10 @@ def parse_id_literal(ast, _variables=None):
 )
 
 
-specified_scalar_types = {
+specified_scalar_types = ReadOnlyDict({
     type_.name: type_
     for type_ in (GraphQLString, GraphQLInt, GraphQLFloat, GraphQLBoolean, GraphQLID)
-}
+})
 
 
 def is_specified_scalar_type(type_: Any) -> bool:

graphql/validation/specified_rules.py

@@ -1,5 +1,7 @@
 from typing import List
 
+from ..pyutils import ReadOnlyList
+
 from .rules import RuleType
 
 # Spec Section: "Executable Definitions"
@@ -99,7 +101,7 @@
 # The order of the rules in this list has been adjusted to lead to the
 # most clear output when encountering multiple validation errors.
 
-specified_rules: List[RuleType] = [
+specified_rules: List[RuleType] = ReadOnlyList([
     ExecutableDefinitionsRule,
     UniqueOperationNamesRule,
     LoneAnonymousOperationRule,
@@ -126,9 +128,9 @@
     VariablesInAllowedPositionRule,
     OverlappingFieldsCanBeMergedRule,
     UniqueInputFieldNamesRule,
-]
+])
 
-specified_sdl_rules: List[RuleType] = [
+specified_sdl_rules: List[RuleType] = ReadOnlyList([
     LoneSchemaDefinitionRule,
     UniqueOperationTypesRule,
     UniqueTypeNamesRule,
@@ -143,4 +145,4 @@
     UniqueArgumentNamesRule,
     UniqueInputFieldNamesRule,
     ProvidedRequiredArgumentsOnDirectivesRule,
-]
+])

tests/pyutils/test_read_only_list.py

@@ -66,6 +66,7 @@ def cannot_write():
             rol.sort()
         with raises(ReadOnlyError):
             rol.reverse()
+        assert rol == [1, 2, 3]
 
     def can_add_rol():
         rol1 = ReadOnlyList([1, 2])
@@ -75,6 +76,3 @@ def can_add_rol():
     def can_add_tuple():
         rol = ReadOnlyList([1, 2])
         assert rol + (3, 4) == [1, 2, 3, 4]
-
-    def read_only_error_is_type_error():
-        assert issubclass(ReadOnlyError, TypeError)