verlappingFieldsCanBeMergedRule: simplify argument comparison

Replicates graphql/graphql-js@5caff03

Author: Cito

src/graphql/validation/rules/overlapping_fields_can_be_merged.py

@@ -1,15 +1,15 @@
 from itertools import chain
-from typing import Any, Collection, Dict, List, Optional, Tuple, Union, cast
+from typing import Any, Dict, List, Optional, Tuple, Union, cast
 
 from ...error import GraphQLError
 from ...language import (
-    ArgumentNode,
     FieldNode,
     FragmentDefinitionNode,
     FragmentSpreadNode,
     InlineFragmentNode,
+    ObjectFieldNode,
+    ObjectValueNode,
     SelectionSetNode,
-    ValueNode,
     print_ast,
 )
 from ...type import (
@@ -551,7 +551,7 @@ def find_conflict(
             )
 
         # Two field calls must have the same arguments.
-        if not same_arguments(node1.arguments or [], node2.arguments or []):
+        if stringify_arguments(node1) != stringify_arguments(node2):
             return (response_name, "they have differing arguments"), [node1], [node2]
 
     if type1 and type2 and do_types_conflict(type1, type2):
@@ -582,24 +582,14 @@ def find_conflict(
     return None  # no conflict
 
 
-def same_arguments(
-    arguments1: Collection[ArgumentNode], arguments2: Collection[ArgumentNode]
-) -> bool:
-    if len(arguments1) != len(arguments2):
-        return False
-    for argument1 in arguments1:
-        for argument2 in arguments2:
-            if argument2.name.value == argument1.name.value:
-                if stringify_value(argument1.value) != stringify_value(argument2.value):
-                    return False
-                break
-        else:
-            return False
-    return True
-
-
-def stringify_value(value: ValueNode) -> str:
-    return print_ast(sort_value_node(value))
+def stringify_arguments(field_node: FieldNode) -> str:
+    input_object_with_args = ObjectValueNode(
+        fields=tuple(
+            ObjectFieldNode(name=arg_node.name, value=arg_node.value)
+            for arg_node in field_node.arguments
+        )
+    )
+    return print_ast(sort_value_node(input_object_with_args))
 
 
 def do_types_conflict(type1: GraphQLOutputType, type2: GraphQLOutputType) -> bool: