Improved exception reporting

Author: syrusakbary

graphql/error/base.py

@@ -43,4 +43,4 @@ def locations(self):
             source = self.source
             if self.positions and source:
                 self._locations = [get_location(source, pos) for pos in self.positions]
-        return self._locations
+        return self._locations

graphql/execution/base.py

@@ -1,4 +1,6 @@
 # -*- coding: utf-8 -*-
+import sys
+
 from ..error import GraphQLError
 from ..language import ast
 from ..pyutils.default_ordered_dict import DefaultOrderedDict
@@ -13,9 +15,10 @@
 class _Undefined(object):
     def __bool__(self):
         return False
-    
+
     __nonzero__ = __bool__
 
+
 Undefined = _Undefined()
 
 
@@ -89,6 +92,10 @@ def get_argument_values(self, field_def, field_ast):
 
         return result
 
+    def report_error(self, error, traceback=None):
+        sys.excepthook(type(error), str(error), getattr(error, 'stack', None) or traceback)
+        self.errors.append(error)
+
     def get_sub_fields(self, return_type, field_asts):
         k = return_type, tuple(field_asts)
         if k not in self._subfields_cache:

graphql/execution/executor.py

@@ -63,8 +63,8 @@ def execute(schema, document_ast, root_value=None, context_value=None,
         middleware
     )
 
-    def executor(resolve, reject):
-        return resolve(execute_operation(context, context.operation, root_value))
+    def executor(v):
+        return execute_operation(context, context.operation, root_value)
 
     def on_rejected(error):
         context.errors.append(error)
@@ -75,7 +75,7 @@ def on_resolve(data):
             return ExecutionResult(data=data)
         return ExecutionResult(data=data, errors=context.errors)
 
-    promise = Promise(executor).catch(on_rejected).then(on_resolve)
+    promise = Promise.resolve(None).then(executor).catch(on_rejected).then(on_resolve)
     if return_promise:
         return promise
     context.executor.wait_until_finished()
@@ -218,14 +218,16 @@ def complete_value_catching_error(exe_context, return_type, field_asts, info, re
         completed = complete_value(exe_context, return_type, field_asts, info, result)
         if is_thenable(completed):
             def handle_error(error):
-                exe_context.errors.append(error)
+                traceback = completed._traceback
+                exe_context.report_error(error, traceback)
                 return None
 
             return completed.catch(handle_error)
 
         return completed
     except Exception as e:
-        exe_context.errors.append(e)
+        traceback = sys.exc_info()[2]
+        exe_context.report_error(e, traceback)
         return None
 
 

graphql/execution/executors/utils.py

@@ -1,6 +1,11 @@
+from sys import exc_info
+
+
 def process(p, f, args, kwargs):
     try:
         val = f(*args, **kwargs)
         p.do_resolve(val)
     except Exception as e:
-        p.do_reject(e)
+        traceback = exc_info()[2]
+        e.stack = traceback
+        p.do_reject(e, traceback=traceback)