Switch argument ordering for core.utils.value_from_ast to match reference implementation.

Author: jhgg

graphql/core/execution/values.py

@@ -51,8 +51,8 @@ def get_argument_values(arg_defs, arg_asts, variables):
             value_ast = value_ast.value
 
         value = value_from_ast(
-            arg_def.type,
             value_ast,
+            arg_def.type,
             variables
         )
 
@@ -84,7 +84,8 @@ def get_variable_value(schema, definition_ast, input):
         if is_nullish(input):
             default_value = definition_ast.default_value
             if default_value:
-                return value_from_ast(type, default_value, None)
+                return value_from_ast(default_value, type)
+
         return coerce_value(type, input)
 
     if is_nullish(input):

graphql/core/utils/value_from_ast.py

@@ -3,13 +3,13 @@
 from .is_nullish import is_nullish
 
 
-def value_from_ast(type, value_ast, variables):
+def value_from_ast(value_ast, type, variables=None):
     """Given a type and a value AST node known to match this type, build a
     runtime value."""
     if isinstance(type, GraphQLNonNull):
         # Note: we're not checking that the result of coerceValueAST is non-null.
         # We're assuming that this query has been validated and the value used here is of the correct type.
-        return value_from_ast(type.of_type, value_ast, variables)
+        return value_from_ast(value_ast, type.of_type, variables)
 
     if not value_ast:
         return None
@@ -18,37 +18,46 @@ def value_from_ast(type, value_ast, variables):
         variable_name = value_ast.name.value
         if not variables or variable_name not in variables:
             return None
+
         # Note: we're not doing any checking that this variable is correct. We're assuming that this query
         # has been validated and the variable usage here is of the correct type.
         return variables[variable_name]
 
     if isinstance(type, GraphQLList):
         item_type = type.of_type
         if isinstance(value_ast, ast.ListValue):
-            return [value_from_ast(item_type, item_ast, variables)
+            return [value_from_ast(item_ast, item_type, variables)
                     for item_ast in value_ast.values]
+
         else:
-            return [value_from_ast(item_type, value_ast, variables)]
+            return [value_from_ast(value_ast, item_type, variables)]
 
     if isinstance(type, GraphQLInputObjectType):
         fields = type.get_fields()
         if not isinstance(value_ast, ast.ObjectValue):
             return None
+
         field_asts = {}
+
         for field in value_ast.fields:
             field_asts[field.name.value] = field
+
         obj = {}
         for field_name, field in fields.items():
             field_ast = field_asts.get(field_name)
             field_value_ast = None
+
             if field_ast:
                 field_value_ast = field_ast.value
+
             field_value = value_from_ast(
-                field.type, field_value_ast, variables
+                field_value_ast, field.type, variables
             )
             if field_value is None:
                 field_value = field.default_value
+
             obj[field_name] = field_value
+
         return obj
 
     assert isinstance(type, (GraphQLScalarType, GraphQLEnumType)), \