Implement ArgumentsOfCorrectType

Implement some unit tests. (there’s a lot left!)

Author: jhgg

graphql/core/validation/rules.py

@@ -511,7 +511,18 @@ def duplicate_arg_message(field):
 
 
 class ArgumentsOfCorrectType(ValidationRule):
-    pass
+    def enter_Argument(self, node, *args):
+        arg_def = self.context.get_argument()
+        if arg_def and not is_valid_literal_value(arg_def.type, node.value):
+            return GraphQLError(
+                self.bad_value_message(node.name.value, arg_def.type,
+                                       print_ast(node.value)),
+                [node.value]
+            )
+
+    @staticmethod
+    def bad_value_message(arg_name, type, value):
+        return 'Argument "{}" expected type "{}" but got: {}.'.format(arg_name, type, value)
 
 
 class ProvidedNonNullArguments(ValidationRule):

tests/core_validation/test_arguments_of_correct_type.py

@@ -0,0 +1,96 @@
+from graphql.core.language.location import SourceLocation
+from graphql.core.validation.rules import ArgumentsOfCorrectType
+from utils import expect_passes_rule, expect_fails_rule
+
+
+def bad_value(arg_name, type_name, value, line, column):
+    return {
+        'message': ArgumentsOfCorrectType.bad_value_message(arg_name, type_name, value),
+        'locations': [SourceLocation(line, column)]
+    }
+
+
+def test_good_int_value():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+            intArgField(intArg: 2)
+        }
+    }
+    ''')
+
+
+def test_good_boolean_value():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+          booleanArgField(booleanArg: true)
+        }
+    }
+    ''')
+
+
+def test_good_string_value():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+            stringArgField(stringArg: "foo")
+        }
+    }
+    ''')
+
+
+def test_good_float_value():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+            floatArgField(floatArg: 1.1)
+        }
+    }
+    ''')
+
+
+def test_int_into_float():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+            floatArgField(floatArg: 1)
+        }
+    }
+    ''')
+
+
+def test_int_into_id():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+          idArgField(idArg: 1)
+        }
+    }
+    ''')
+
+
+def test_string_into_id():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        complicatedArgs {
+          idArgField(idArg: "someIdString")
+        }
+    }
+    ''')
+
+
+def test_good_enum_value():
+    expect_passes_rule(ArgumentsOfCorrectType, '''
+    {
+        dog {
+            doesKnowCommand(dogCommand: SIT)
+        }
+    }
+    ''')
+
+#
+# def test_int_into_string():
+#     expect_passes_rule(ArgumentsOfCorrectType, '''
+#
+#     ''')