[Validation] Factor out and memoize recursively referenced fragments.

Related GraphQL commit: graphql/graphql-js@eef8d97

Author: syrusakbary

graphql/core/validation/context.py

@@ -2,18 +2,39 @@
 
 
 class ValidationContext(object):
-    __slots__ = '_schema', '_ast', '_type_info', '_fragments', '_fragment_spreads'
+    __slots__ = '_schema', '_ast', '_type_info', '_fragments', '_fragment_spreads', '_recursively_referenced_fragments'
 
     def __init__(self, schema, ast, type_info):
         self._schema = schema
         self._ast = ast
         self._type_info = type_info
         self._fragments = None
         self._fragment_spreads = {}
+        self._recursively_referenced_fragments = {}
 
     def get_schema(self):
         return self._schema
 
+    def get_recursively_referenced_fragments(self, operation):
+        fragments = self._recursively_referenced_fragments.get(operation)
+        if not fragments:
+            fragments = []
+            collected_names = set()
+            nodes_to_visit = [operation]
+            while nodes_to_visit:
+                node = nodes_to_visit.pop()
+                spreads = self.get_fragment_spreads(node)
+                for spread in spreads:
+                    frag_name = spread.name.value
+                    if frag_name not in collected_names:
+                        collected_names.add(frag_name)
+                        fragment = self.get_fragment(frag_name)
+                        if fragment:
+                            fragments.append(fragment)
+                            nodes_to_visit.append(fragment)
+            self._recursively_referenced_fragments[operation] = fragments
+        return fragments
+
     def get_fragment_spreads(self, node):
         spreads = self._fragment_spreads.get(node)
         if not spreads:

graphql/core/validation/rules/no_unused_fragments.py

@@ -3,15 +3,15 @@
 
 
 class NoUnusedFragments(ValidationRule):
-    __slots__ = 'fragment_definitions', 'spreads_within_operation', 'fragment_adjacencies', 'spread_names'
+    __slots__ = 'fragment_definitions', 'operation_definitions', 'fragment_adjacencies', 'spread_names'
 
     def __init__(self, context):
         super(NoUnusedFragments, self).__init__(context)
-        self.spreads_within_operation = []
+        self.operation_definitions = []
         self.fragment_definitions = []
 
     def enter_OperationDefinition(self, node, key, parent, path, ancestors):
-        self.spreads_within_operation.append(self.context.get_fragment_spreads(node))
+        self.operation_definitions.append(node)
         return False
 
     def enter_FragmentDefinition(self, node, key, parent, path, ancestors):
@@ -21,19 +21,10 @@ def enter_FragmentDefinition(self, node, key, parent, path, ancestors):
     def leave_Document(self, node, key, parent, path, ancestors):
         fragment_names_used = set()
 
-        def reduce_spread_fragments(spreads):
-            for spread in spreads:
-                frag_name = spread.name.value
-                if frag_name in fragment_names_used:
-                    continue
-
-                fragment_names_used.add(frag_name)
-                fragment = self.context.get_fragment(frag_name)
-                if fragment:
-                    reduce_spread_fragments(self.context.get_fragment_spreads(fragment))
-
-        for spreads in self.spreads_within_operation:
-            reduce_spread_fragments(spreads)
+        for operation in self.operation_definitions:
+            fragments = self.context.get_recursively_referenced_fragments(operation)
+            for fragment in fragments:
+                fragment_names_used.add(fragment.name.value)
 
         errors = [
             GraphQLError(