Code review fixes

Author: jkimbo

graphql/type/definition.py

@@ -406,10 +406,10 @@ def __init__(self, name, values, description=None):
 
         self.values = define_enum_values(self, values)
 
-    def getValues(self):
+    def get_values(self):
         return self.values
 
-    def getValue(self, name):
+    def get_value(self, name):
         return self._name_lookup.get(name)
 
     def serialize(self, value):
@@ -476,14 +476,17 @@ class Undefined(object):
 
 
 class GraphQLEnumValue(object):
-    __slots__ = 'name', 'value', 'is_deprecated', 'deprecation_reason', 'description'
+    __slots__ = 'name', 'value', 'deprecation_reason', 'description'
 
     def __init__(self, value=Undefined, deprecation_reason=None, description=None, name=None):
         self.name = name
         self.value = value
         self.deprecation_reason = deprecation_reason
         self.description = description
-        self.is_deprecated = bool(deprecation_reason)
+
+    @property
+    def is_deprecated(self):
+        return bool(self.deprecation_reason)
 
     def __eq__(self, other):
         return (

graphql/type/tests/test_definition.py

@@ -122,7 +122,7 @@ def test_defines_an_enum_type_with_deprecated_value():
     EnumTypeWithDeprecatedValue = GraphQLEnumType('EnumWithDeprecatedValue', {
         'foo': GraphQLEnumValue(deprecation_reason='Just because'),
     })
-    value = EnumTypeWithDeprecatedValue.getValues()[0]
+    value = EnumTypeWithDeprecatedValue.get_values()[0]
     assert value.name == 'foo'
     assert value.description is None
     assert value.is_deprecated is True
@@ -135,7 +135,7 @@ def test_defines_an_enum_type_with_a_value_of_none():
         'NULL': GraphQLEnumValue(None),
     })
 
-    value = EnumTypeWithNoneValue.getValues()[0]
+    value = EnumTypeWithNoneValue.get_values()[0]
     assert value.name == 'NULL'
     assert value.description is None
     assert value.is_deprecated is False

graphql/type/tests/test_enum_type.py

@@ -212,8 +212,8 @@ def test_enum_inputs_may_be_nullable():
     assert result.data == {'colorEnum': None, 'colorInt': None}
 
 
-def test_presents_a_getValues_api():
-    values = ColorType.getValues()
+def test_presents_a_get_values_api():
+    values = ColorType.get_values()
     assert len(values) == 3
     assert values[0].name == 'RED'
     assert values[0].value == 0
@@ -223,12 +223,12 @@ def test_presents_a_getValues_api():
     assert values[2].value == 2
 
 
-def test_presents_a_getValue_api():
-    oneValue = ColorType.getValue('RED')
+def test_presents_a_get_value_api():
+    oneValue = ColorType.get_value('RED')
     assert oneValue.name == 'RED'
     assert oneValue.value == 0
 
-    badUsage = ColorType.getValue(0)
+    badUsage = ColorType.get_value(0)
     assert badUsage is None