Add missing test case and cleanup

Author: dittos

graphql/core/validation/rules.py

@@ -659,19 +659,19 @@ def effective_type(var_type, var_def):
 
         return GraphQLNonNull(var_type)
 
-    @staticmethod
-    def var_type_allowed_for_type(var_type, expected_type):
+    @classmethod
+    def var_type_allowed_for_type(cls, var_type, expected_type):
         if isinstance(expected_type, GraphQLNonNull):
             if isinstance(var_type, GraphQLNonNull):
-                return VariablesInAllowedPosition.var_type_allowed_for_type(var_type.of_type, expected_type.of_type)
+                return cls.var_type_allowed_for_type(var_type.of_type, expected_type.of_type)
 
             return False
 
         if isinstance(var_type, GraphQLNonNull):
-            return VariablesInAllowedPosition.var_type_allowed_for_type(var_type.of_type, expected_type)
+            return cls.var_type_allowed_for_type(var_type.of_type, expected_type)
 
         if isinstance(var_type, GraphQLList) and isinstance(expected_type, GraphQLList):
-            return VariablesInAllowedPosition.var_type_allowed_for_type(var_type.of_type, expected_type.of_type)
+            return cls.var_type_allowed_for_type(var_type.of_type, expected_type.of_type)
 
         return var_type == expected_type
 

tests/core_validation/test_variables_in_allowed_position.py

@@ -50,7 +50,22 @@ def test_non_null_boolean_boolean():
       }
     ''')
 
-def test_int_non_nll_int_with_default():
+
+def test_non_null_boolean_to_boolean_within_fragment():
+    expect_passes_rule(VariablesInAllowedPosition, '''
+      fragment booleanArgFrag on ComplicatedArgs {
+        booleanArgField(booleanArg: $nonNullBooleanArg)
+      }
+      query Query($nonNullBooleanArg: Boolean!)
+      {
+        complicatedArgs {
+          ...booleanArgFrag
+        }
+      }
+    ''')
+
+
+def test_int_non_null_int_with_default():
     expect_passes_rule(VariablesInAllowedPosition, '''
       query Query($intArg: Int = 1)
       {
@@ -230,4 +245,4 @@ def test_string_non_null_boolean_in_directive():
     ''', [
       { 'message': VariablesInAllowedPosition.bad_var_pos_message('stringVar', 'String', 'Boolean!'),
         'locations': [SourceLocation(4, 26)] }
-    ])
+    ])