added tests, updated docs, allow for subclassing SQLAlchemyObjectType

Author: dfee

README.md

@@ -68,6 +68,38 @@ query = '''
 result = schema.execute(query, context_value={'session': db_session})
 ```
 
+You may also subclass SQLAlchemyObjectType by providing `abstract = True` in
+your subclasses Meta:
+```python
+from graphene_sqlalchemy import SQLAlchemyObjectType
+
+class ActiveSQLAlchemyObjectType(SQLAlchemyObjectType):
+    class Meta:
+        abstract = True
+
+    @classmethod
+    def get_node(cls, id, context, info):
+        return cls.get_query(context).\
+            filter(and_(
+                cls._meta.model.deleted_at==None,
+                cls._meta.model.id==id,
+            )).\
+            first()
+
+class User(ActiveSQLAlchemyObjectType):
+    class Meta:
+        model = UserModel
+
+class Query(graphene.ObjectType):
+    users = graphene.List(User)
+
+    def resolve_users(self, args, context, info):
+        query = User.get_query(context) # SQLAlchemy query
+        return query.all()
+
+schema = graphene.Schema(query=Query)
+```
+
 To learn more check out the following [examples](examples/):
 
 * **Full example**: [Flask SQLAlchemy example](examples/flask_sqlalchemy)

graphene_sqlalchemy/tests/test_types.py

@@ -79,25 +79,9 @@ def test_object_type():
 
 
 # Test Custom SQLAlchemyObjectType Implementation
-class CustomSQLAlchemyObjectType(six.with_metaclass(SQLAlchemyObjectTypeMeta, ObjectType)):
-    @classmethod
-    def is_type_of(cls, root, context, info):
-        return SQLAlchemyObjectType.is_type_of(root, context, info)
-
-    @classmethod
-    def get_query(cls, context):
-        return SQLAlchemyObjectType.get_query(context)
-
-    @classmethod
-    def get_node(cls, id, context, info):
-        return SQLAlchemyObjectType.get_node(id, context, info)
-
-    @classmethod
-    def resolve_id(self, args, context, info):
-        graphene_type = info.parent_type.graphene_type
-        if is_node(graphene_type):
-            return self.__mapper__.primary_key_from_instance(self)[0]
-        return getattr(self, graphene_type._meta.id, None)
+class CustomSQLAlchemyObjectType(SQLAlchemyObjectType):
+    class Meta:
+        abstract = True
 
 
 class CustomCharacter(CustomSQLAlchemyObjectType):
@@ -106,6 +90,7 @@ class Meta:
         model = Reporter
         registry = registry
 
+
 def test_custom_objecttype_registered():
     assert issubclass(CustomCharacter, ObjectType)
     assert CustomCharacter._meta.model == Reporter

graphene_sqlalchemy/types.py

@@ -82,9 +82,15 @@ def __new__(cls, name, bases, attrs):
             exclude_fields=(),
             id='id',
             interfaces=(),
-            registry=None
+            registry=None,
+            abstract=False,
         )
 
+        cls = ObjectTypeMeta.__new__(cls, name, bases, dict(attrs, _meta=options))
+
+        if options.abstract:
+            return cls
+
         if not options.registry:
             options.registry = get_global_registry()
         assert isinstance(options.registry, Registry), (
@@ -96,8 +102,6 @@ def __new__(cls, name, bases, attrs):
             '{}.Meta, received "{}".'
         ).format(name, options.model)
 
-        cls = ObjectTypeMeta.__new__(cls, name, bases, dict(attrs, _meta=options))
-
         options.registry.register(cls)
 
         options.sqlalchemy_fields = yank_fields_from_attrs(
@@ -115,6 +119,8 @@ def __new__(cls, name, bases, attrs):
 
 
 class SQLAlchemyObjectType(six.with_metaclass(SQLAlchemyObjectTypeMeta, ObjectType)):
+    class Meta:
+        abstract = True
 
     @classmethod
     def is_type_of(cls, root, context, info):