Skip to content

Commit b6d24bc

Browse files
committed
fix: request scoped dataloader tests
1 parent 0b68075 commit b6d24bc

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

request-scoped-dataloader/src/main/java/graphql/servlet/examples/dataloader/requestscope/CustomGraphQLContextBuilder.java

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22

33
import static java.util.concurrent.CompletableFuture.supplyAsync;
44

5-
import graphql.kickstart.execution.context.DefaultGraphQLContext;
6-
import graphql.kickstart.execution.context.GraphQLContext;
7-
import graphql.kickstart.servlet.context.DefaultGraphQLServletContext;
8-
import graphql.kickstart.servlet.context.DefaultGraphQLWebSocketContext;
5+
import graphql.kickstart.execution.context.GraphQLKickstartContext;
96
import graphql.kickstart.servlet.context.GraphQLServletContextBuilder;
107
import javax.servlet.http.HttpServletRequest;
118
import javax.servlet.http.HttpServletResponse;
@@ -25,24 +22,18 @@ public CustomGraphQLContextBuilder(CustomerRepository customerRepository) {
2522
}
2623

2724
@Override
28-
public GraphQLContext build(HttpServletRequest req, HttpServletResponse response) {
29-
return DefaultGraphQLServletContext.createServletContext(buildDataLoaderRegistry(), null)
30-
.with(req)
31-
.with(response)
32-
.build();
25+
public GraphQLKickstartContext build(HttpServletRequest req, HttpServletResponse response) {
26+
return GraphQLKickstartContext.of(buildDataLoaderRegistry());
3327
}
3428

3529
@Override
36-
public GraphQLContext build() {
37-
return new DefaultGraphQLContext(buildDataLoaderRegistry(), null);
30+
public GraphQLKickstartContext build() {
31+
return GraphQLKickstartContext.of(buildDataLoaderRegistry());
3832
}
3933

4034
@Override
41-
public GraphQLContext build(Session session, HandshakeRequest request) {
42-
return DefaultGraphQLWebSocketContext.createWebSocketContext(buildDataLoaderRegistry(), null)
43-
.with(session)
44-
.with(request)
45-
.build();
35+
public GraphQLKickstartContext build(Session session, HandshakeRequest request) {
36+
return GraphQLKickstartContext.of(buildDataLoaderRegistry());
4637
}
4738

4839
private DataLoaderRegistry buildDataLoaderRegistry() {

request-scoped-dataloader/src/main/java/graphql/servlet/examples/dataloader/requestscope/CustomerResolver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package graphql.servlet.examples.dataloader.requestscope;
22

3-
import graphql.kickstart.execution.context.GraphQLContext;
43
import graphql.kickstart.tools.GraphQLResolver;
54
import graphql.schema.DataFetchingEnvironment;
65
import java.util.concurrent.CompletableFuture;
@@ -12,7 +11,7 @@
1211
public class CustomerResolver implements GraphQLResolver<Customer> {
1312

1413
public CompletableFuture<String> getName(Customer customer, DataFetchingEnvironment dfe) {
15-
DataLoaderRegistry registry = ((GraphQLContext) dfe.getContext()).getDataLoaderRegistry();
14+
DataLoaderRegistry registry = dfe.getDataLoaderRegistry();
1615
DataLoader<Integer, String> customerLoader = registry.getDataLoader("customerDataLoader");
1716
if (customerLoader != null) {
1817
return customerLoader.load(customer.getCustomerId());

0 commit comments

Comments
 (0)