Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit c6ad861

Browse files
committed
Removed creation of custom ObjectMapper and rely on Jackson (fix #140)
1 parent 5425c50 commit c6ad861

File tree

2 files changed

+7
-18
lines changed

2 files changed

+7
-18
lines changed

graphql-spring-boot-autoconfigure/src/main/java/com/oembedler/moon/graphql/boot/GraphQLJavaToolsAutoConfiguration.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import java.io.IOException;
1919
import java.util.List;
20-
import java.util.Optional;
2120

2221
import static com.coxautodev.graphql.tools.SchemaParserOptions.newOptions;
2322

@@ -43,19 +42,13 @@ public SchemaStringProvider schemaStringProvider() {
4342
return new ClasspathResourceSchemaStringProvider();
4443
}
4544

46-
@Bean
47-
@ConditionalOnMissingBean
48-
public ObjectMapper objectMapper() {
49-
return new ObjectMapper();
50-
}
51-
5245
@Bean
5346
@ConditionalOnBean({GraphQLResolver.class})
5447
@ConditionalOnMissingBean
5548
public SchemaParser schemaParser(
5649
List<GraphQLResolver<?>> resolvers,
5750
SchemaStringProvider schemaStringProvider,
58-
Optional<PerFieldObjectMapperProvider> perFieldObjectMapperProvider
51+
PerFieldObjectMapperProvider perFieldObjectMapperProvider
5952
) throws IOException {
6053
SchemaParserBuilder builder = dictionary != null ? new SchemaParserBuilder(dictionary) : new SchemaParserBuilder();
6154

@@ -68,9 +61,9 @@ public SchemaParser schemaParser(
6861

6962
if (options != null) {
7063
builder.options(options);
71-
} else if (perFieldObjectMapperProvider.isPresent()) {
64+
} else if (perFieldObjectMapperProvider != null) {
7265
final SchemaParserOptions.Builder optionsBuilder =
73-
newOptions().objectMapperProvider(perFieldObjectMapperProvider.get());
66+
newOptions().objectMapperProvider(perFieldObjectMapperProvider);
7467
builder.options(optionsBuilder.build());
7568
}
7669

graphql-spring-boot-autoconfigure/src/main/java/com/oembedler/moon/graphql/boot/GraphQLWebAutoConfiguration.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
import org.springframework.boot.web.servlet.ServletRegistrationBean;
5757
import org.springframework.context.annotation.Bean;
5858
import org.springframework.context.annotation.Configuration;
59+
import org.springframework.context.annotation.DependsOn;
5960
import org.springframework.web.cors.UrlBasedCorsConfigurationSource;
6061
import org.springframework.web.filter.CorsFilter;
6162
import org.springframework.web.servlet.DispatcherServlet;
@@ -205,15 +206,15 @@ public GraphQLQueryInvoker queryInvoker(ExecutionStrategyProvider executionStrat
205206

206207
@Bean
207208
@ConditionalOnMissingBean
208-
public GraphQLObjectMapper graphQLObjectMapper(Optional<ObjectMapperProvider> objectMapperProvider) {
209+
public GraphQLObjectMapper graphQLObjectMapper(ObjectMapperProvider objectMapperProvider) {
209210
GraphQLObjectMapper.Builder builder = newBuilder();
210211

211212
if (errorHandler != null) {
212213
builder.withGraphQLErrorHandler(errorHandler);
213214
}
214215

215-
if (objectMapperProvider.isPresent()){
216-
builder.withObjectMapperProvider(objectMapperProvider.get());
216+
if (objectMapperProvider != null){
217+
builder.withObjectMapperProvider(objectMapperProvider);
217218
} else if (objectMapperConfigurer != null) {
218219
builder.withObjectMapperConfigurer(objectMapperConfigurer);
219220
}
@@ -256,9 +257,4 @@ private MultipartConfigElement multipartConfigElement() {
256257
return Optional.ofNullable(multipartConfigElement).orElse(new MultipartConfigElement(""));
257258
}
258259

259-
@Bean
260-
@ConditionalOnMissingBean
261-
public ObjectMapper objectMapper() {
262-
return new ObjectMapper();
263-
}
264260
}

0 commit comments

Comments
 (0)