Fix annotation unit test

Author: oliemansm

.github/workflows/pull-request.yml

@@ -1,8 +1,5 @@
 name: "Pull request"
 on:
-  push:
-    branches-ignore:
-      - master
   pull_request:
     types: [ opened, synchronize, reopened ]
 

graphql-spring-boot-test/src/main/java/com/graphql/spring/boot/test/GraphQLTestSubscription.java

@@ -116,7 +116,7 @@ public GraphQLTestSubscription init(@Nullable final Object payload) {
     sendMessage(message);
     state.setInitialized(true);
     awaitAcknowledgement();
-    log.debug("Subscription successfully initialized.");
+    log.debug("Subscription successfully initialized");
     return this;
   }
 
@@ -135,12 +135,12 @@ public GraphQLTestSubscription start(@NonNull final String graphQLResource) {
   /**
    * Sends the "start" message to the GraphQL Subscription.
    *
-   * @param graphGLResource the GraphQL resource, which contains the query for the subscription
+   * @param graphQLResource the GraphQL resource, which contains the query for the subscription
    * start payload.
    * @param variables the variables needed for the query to be evaluated.
    * @return self reference
    */
-  public GraphQLTestSubscription start(@NonNull final String graphGLResource,
+  public GraphQLTestSubscription start(@NonNull final String graphQLResource,
       @Nullable final Object variables) {
     if (!isInitialized()) {
       init();
@@ -150,7 +150,7 @@ public GraphQLTestSubscription start(@NonNull final String graphGLResource,
     }
     state.setStarted(true);
     ObjectNode payload = objectMapper.createObjectNode();
-    payload.put("query", loadQuery(graphGLResource));
+    payload.put("query", loadQuery(graphQLResource));
     payload.set("variables", getFinalPayload(variables));
     ObjectNode message = objectMapper.createObjectNode();
     message.put("type", "start");
@@ -335,7 +335,7 @@ public List<GraphQLResponse> awaitAndGetNextResponses(
   }
 
   private boolean hasReachedExpectedResponses(int numExpectedResponses) {
-    return (state.getResponses().size() < numExpectedResponses) || numExpectedResponses <= 0;
+    return (state.getResponses().size() == numExpectedResponses) || numExpectedResponses <= 0;
   }
 
   /**
@@ -419,19 +419,20 @@ private void sendMessage(final Object message) {
 
   private void awaitAcknowledgement() {
     awaitAcknowledgementOrConnection(GraphQLTestSubscription::isAcknowledged,
-        "Connection was not acknowledged by the GraphQL server.");
+        "Connection was acknowledged by the GraphQL server.");
   }
 
   private void awaitStop() {
     awaitAcknowledgementOrConnection(GraphQLTestSubscription::isStopped,
-        "Connection was not stopped in time.");
+        "Connection was stopped in time.");
   }
 
   private void awaitAcknowledgementOrConnection(final Predicate<GraphQLTestSubscription> condition,
       final String timeoutDescription) {
     await(timeoutDescription)
         .atMost(ACKNOWLEDGEMENT_AND_CONNECTION_TIMEOUT, TimeUnit.MILLISECONDS)
         .until(() -> condition.test(this));
+
   }
 
   @RequiredArgsConstructor
@@ -460,7 +461,6 @@ public void onMessage(final String message) {
             break;
           case "data":
           case "error":
-          default:
             final JsonNode payload = jsonNode.get(PAYLOAD);
             assertThat(payload).as("Data/error messages must have a payload.").isNotNull();
             final String payloadString = objectMapper.writeValueAsString(payload);