chore: remove deprecated asyncModeEnabled property

Author: oliemansm

gradle.properties

@@ -32,7 +32,7 @@ TARGET_COMPATIBILITY=1.8
 LIB_GRAPHQL_JAVA_VER=18.3
 LIB_EXTENDED_SCALARS_VER=18.1
 LIB_SPRING_BOOT_VER=2.7.2
-LIB_GRAPHQL_SERVLET_VER=14.0.0-SNAPSHOT
+LIB_GRAPHQL_SERVLET_VER=13.0.1-SNAPSHOT
 LIB_GRAPHQL_JAVA_TOOLS_VER=12.1.0
 LIB_GRAPHQL_ANNOTATIONS_VER=9.1
 LIB_REFLECTIONS_VER=0.10.2

graphql-spring-boot-autoconfigure/src/main/java/graphql/kickstart/autoconfigure/web/servlet/GraphQLWebAutoConfiguration.java

@@ -290,7 +290,8 @@ public GraphQLObjectMapper graphQLObjectMapper(
   @Bean
   @ConditionalOnMissingBean
   @ConditionalOnProperty(
-      value = "graphql.servlet.use-default-objectmapper",
+      prefix = "graphql.servlet",
+      name = "use-default-objectmapper",
       havingValue = "true",
       matchIfMissing = true)
   public ObjectMapperProvider objectMapperProvider(ObjectMapper objectMapper) {
@@ -314,10 +315,6 @@ public GraphQLConfiguration graphQLServletConfiguration(
     Duration asyncTimeout =
         Optional.ofNullable(asyncServletProperties.getTimeout()) //
             .orElse(AsyncServletProperties.DEFAULT_TIMEOUT);
-    long asyncTimeoutMilliseconds =
-        Optional.ofNullable(graphQLServletProperties.getAsyncTimeout()) //
-            .orElse(asyncTimeout)
-            .toMillis();
     long subscriptionTimeoutMilliseconds =
         Optional.ofNullable(graphQLServletProperties.getSubscriptionTimeout()) //
             .orElse(GraphQLServletProperties.DEFAULT_SUBSCRIPTION_TIMEOUT)
@@ -330,7 +327,7 @@ public GraphQLConfiguration graphQLServletConfiguration(
         .with(batchInputPreProcessor)
         .with(graphQLServletProperties.getContextSetting())
         .with(responseCacheManager)
-        .asyncTimeout(asyncTimeoutMilliseconds)
+        .asyncTimeout(asyncTimeout.toMillis())
         .with(asyncTaskDecorator)
         .asyncCorePoolSize(asyncServletProperties.getThreads().getMin())
         .asyncMaxPoolSize(asyncServletProperties.getThreads().getMax())
@@ -340,22 +337,14 @@ public GraphQLConfiguration graphQLServletConfiguration(
 
   @Bean("graphqlAsyncTaskExecutor")
   @ConditionalOnMissingBean(name = "graphqlAsyncTaskExecutor")
+  @ConditionalOnProperty(prefix = "graphql.servlet.async", name = "enabled", havingValue = "true")
   public Executor threadPoolTaskExecutor() {
-    if (isAsyncModeEnabled()) {
-      ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();
-      executor.setCorePoolSize(asyncServletProperties.getThreads().getMin());
-      executor.setMaxPoolSize(asyncServletProperties.getThreads().getMax());
-      executor.setThreadNamePrefix(asyncServletProperties.getThreads().getNamePrefix());
-      executor.initialize();
-      return executor;
-    }
-    return null;
-  }
-
-  private boolean isAsyncModeEnabled() {
-    return graphQLServletProperties.getAsyncModeEnabled() != null
-        ? graphQLServletProperties.getAsyncModeEnabled()
-        : asyncServletProperties.isEnabled();
+    ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();
+    executor.setCorePoolSize(asyncServletProperties.getThreads().getMin());
+    executor.setMaxPoolSize(asyncServletProperties.getThreads().getMax());
+    executor.setThreadNamePrefix(asyncServletProperties.getThreads().getNamePrefix());
+    executor.initialize();
+    return executor;
   }
 
   @Bean
@@ -375,11 +364,7 @@ public ServletRegistrationBean<AbstractGraphQLHttpServlet> graphQLServletRegistr
     } else {
       registration.setMultipartConfig(new MultipartConfigElement(""));
     }
-    if (graphQLServletProperties.getAsyncModeEnabled() != null) {
-      registration.setAsyncSupported(graphQLServletProperties.getAsyncModeEnabled());
-    } else {
-      registration.setAsyncSupported(asyncServletProperties.isEnabled());
-    }
+    registration.setAsyncSupported(asyncServletProperties.isEnabled());
     return registration;
   }
 }