Added unit test to verify incorrect ID input when used in list

Author: oliemansm

src/test/groovy/graphql/kickstart/tools/BuiltInLongIdSpec.groovy

@@ -0,0 +1,81 @@
+package graphql.kickstart.tools
+
+import graphql.GraphQL
+import graphql.execution.AsyncExecutionStrategy
+import graphql.schema.GraphQLSchema
+import spock.lang.Shared
+import spock.lang.Specification
+
+class BuiltInLongIdSpec extends Specification {
+
+    @Shared
+    GraphQL gql
+
+    def setupSpec() {
+        GraphQLSchema schema = SchemaParser.newParser().schemaString('''\
+                        type Query {
+                            itemByLongId(id: ID!): Item!
+                            itemsByLongIds(ids: [ID!]!): [Item!]!
+                        }
+                        
+                        type Item {
+                          id: ID!
+                        }
+                    '''.stripIndent())
+                .resolvers(new QueryWithLongItemResolver())
+                .build()
+                .makeExecutableSchema()
+        gql = GraphQL.newGraphQL(schema)
+                .queryExecutionStrategy(new AsyncExecutionStrategy())
+                .build()
+    }
+
+    def "supports Long as ID as input"() {
+        when:
+        def data = Utils.assertNoGraphQlErrors(gql) {
+            '''
+                {
+                    itemByLongId(id: 1) {
+                        id
+                    }
+                }
+                '''
+        }
+
+        then:
+        data.itemByLongId != null
+        data.itemByLongId.id == "1"
+    }
+
+    def "supports list of Long as ID as input"() {
+        when:
+        def data = Utils.assertNoGraphQlErrors(gql) {
+            '''
+                {
+                    itemsByLongIds(id: [1,2,3]) {
+                        id
+                    }
+                }
+                '''
+        }
+
+        then:
+        data.itemsByLongIds != null
+        data.itemsByLongIds.size == 3
+        data.itemsByLongIds[0].id == "1"
+    }
+
+    class QueryWithLongItemResolver implements GraphQLQueryResolver {
+        Item itemByLongId(Long id) {
+            new Item(id: id)
+        }
+
+        List<Item> itemsByLongIds(List<Long> ids) {
+            ids.collect { new Item(id: it) }
+        }
+    }
+
+    class Item {
+        Long id
+    }
+}

src/test/groovy/graphql/kickstart/tools/EndToEndSpec.groovy

@@ -664,5 +664,4 @@ class EndToEndSpec extends Specification {
         data.arrayItems.collect { it.name } == ['item1', 'item2']
     }
 
-
 }

src/test/kotlin/graphql/kickstart/tools/BuiltInIdAsLongHelper.kt

@@ -0,0 +1,18 @@
+package graphql.kickstart.tools
+
+fun createLongSchema() = SchemaParser.newParser()
+    .schemaString(schemaDefinition)
+    .resolvers(LongQuery())
+    .build()
+    .makeExecutableSchema()
+
+private const val schemaDefinition = """
+
+"""
+
+class LongQuery : GraphQLQueryResolver {
+  fun itemByLongId(id: Long) = LongItem(id)
+  fun itemsByListOfLongId(ids: List<Long>) = ids.map { id -> LongItem(id) }
+}
+
+data class LongItem(val id: Long)

src/test/kotlin/graphql/kickstart/tools/EndToEndSpecHelper.kt

@@ -26,7 +26,7 @@ fun createSchema() = SchemaParser.newParser()
     .build()
     .makeExecutableSchema()
 
-val schemaDefinition = """
+private const val schemaDefinition = """
 
 ## Private comment!
 scalar UUID
@@ -82,9 +82,6 @@ type Query {
     coroutineItems: [Item!]!
 
     arrayItems: [Item!]!
-    
-    byLongId(id: ID!): Item!
-    byListOfLongId(ids: [ID!]!): [Item!]!
 }
 
 type ExtendedType {