Skip to content

Commit 70c21b0

Browse files
committed
Rename MissingFieldHandler to MissingFieldResolverHandler.
1 parent 4e98b50 commit 70c21b0

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

src/main/kotlin/graphql/kickstart/tools/MissingFieldHandler.kt renamed to src/main/kotlin/graphql/kickstart/tools/MissingFieldResolverHandler.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ package graphql.kickstart.tools
22

33
import graphql.schema.DataFetchingEnvironment
44

5-
interface MissingFieldHandler {
5+
interface MissingFieldResolverHandler {
66
fun resolve(env: DataFetchingEnvironment?): Any?
77
}

src/main/kotlin/graphql/kickstart/tools/SchemaParserOptions.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import kotlin.reflect.KClass
2121
data class SchemaParserOptions internal constructor(
2222
val contextClass: Class<*>?,
2323
val genericWrappers: List<GenericWrapper>,
24-
val missingFieldHandler: MissingFieldHandler?,
24+
val missingFieldResolverHandler: MissingFieldResolverHandler?,
2525
val allowUnimplementedResolvers: Boolean,
2626
val objectMapperProvider: PerFieldObjectMapperProvider,
2727
val proxyHandlers: List<ProxyHandler>,
@@ -48,7 +48,7 @@ data class SchemaParserOptions internal constructor(
4848
private var contextClass: Class<*>? = null
4949
private val genericWrappers: MutableList<GenericWrapper> = mutableListOf()
5050
private var useDefaultGenericWrappers = true
51-
private var missingFieldHandler: MissingFieldHandler? = null
51+
private var missingFieldResolverHandler: MissingFieldResolverHandler? = null
5252
private var allowUnimplementedResolvers = false
5353
private var objectMapperProvider: PerFieldObjectMapperProvider = PerFieldConfiguringObjectMapperProvider()
5454
private val proxyHandlers: MutableList<ProxyHandler> = mutableListOf(Spring4AopProxyHandler(), GuiceAopProxyHandler(), JavassistProxyHandler(), WeldProxyHandler())
@@ -79,8 +79,8 @@ data class SchemaParserOptions internal constructor(
7979
this.useDefaultGenericWrappers = useDefaultGenericWrappers
8080
}
8181

82-
fun missingFieldHandler(missingFieldHandler: MissingFieldHandler?) = this.apply {
83-
this.missingFieldHandler = missingFieldHandler
82+
fun missingFieldResolverHandler(missingFieldResolverHandler: MissingFieldResolverHandler?) = this.apply {
83+
this.missingFieldResolverHandler = missingFieldResolverHandler
8484
}
8585

8686
fun allowUnimplementedResolvers(allowUnimplementedResolvers: Boolean) = this.apply {
@@ -160,7 +160,7 @@ data class SchemaParserOptions internal constructor(
160160
return SchemaParserOptions(
161161
contextClass,
162162
wrappers,
163-
missingFieldHandler,
163+
missingFieldResolverHandler,
164164
allowUnimplementedResolvers,
165165
objectMapperProvider,
166166
proxyHandlers,

src/main/kotlin/graphql/kickstart/tools/resolver/FieldResolverScanner.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ internal class FieldResolverScanner(val options: SchemaParserOptions) {
6464
}
6565

6666
private fun missingFieldResolver(field: FieldDefinition, searches: List<Search>, scanProperties: Boolean): FieldResolver {
67-
return if (options.allowUnimplementedResolvers || options.missingFieldHandler != null) {
67+
return if (options.allowUnimplementedResolvers || options.missingFieldResolverHandler != null) {
6868
if (options.allowUnimplementedResolvers) {
6969
log.warn("Missing resolver for field: $field")
7070
}

src/main/kotlin/graphql/kickstart/tools/resolver/MissingFieldResolver.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ internal class MissingFieldResolver(
1414

1515
override fun scanForMatches(): List<TypeClassMatcher.PotentialMatch> = listOf()
1616
override fun createDataFetcher(): DataFetcher<*> {
17-
val handler = options.missingFieldHandler ?: return NotImplementedMissingFieldDataFetcher()
17+
val handler = options.missingFieldResolverHandler ?: return NotImplementedMissingFieldDataFetcher()
1818
return MissingFieldDataFetcher(handler)
1919
}
2020

21-
class MissingFieldDataFetcher(private val handler: MissingFieldHandler): DataFetcher<Any?> {
21+
class MissingFieldDataFetcher(private val handler: MissingFieldResolverHandler): DataFetcher<Any?> {
2222
override fun get(p0: DataFetchingEnvironment?): Any? {
2323
return handler.resolve(p0)
2424
}

src/test/kotlin/graphql/kickstart/tools/MissingFieldResolverTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class MissingFieldResolverTest {
4141
fun implementedField(input: Optional<String>) = input.toString()
4242
})
4343
.options(SchemaParserOptions.newOptions()
44-
.missingFieldHandler(TestMissingFieldHandler())
44+
.missingFieldResolverHandler(TestMissingFieldResolverHandler())
4545
.build())
4646
.build()
4747
.makeExecutableSchema()
@@ -67,7 +67,7 @@ class MissingFieldResolverTest {
6767
Assert.assertEquals(expected, result.getData())
6868
}
6969

70-
class TestMissingFieldHandler: MissingFieldHandler {
70+
class TestMissingFieldResolverHandler: MissingFieldResolverHandler {
7171
override fun resolve(env: DataFetchingEnvironment?): Any? {
7272
return env?.getArgument("input");
7373
}

0 commit comments

Comments
 (0)