Minor clean up

Author: vojtapol

src/main/kotlin/graphql/kickstart/tools/DictionaryTypeResolver.kt

@@ -44,7 +44,7 @@ internal class InterfaceTypeResolver(
     types: List<GraphQLObjectType>
 ) : DictionaryTypeResolver(
     dictionary,
-    types.filter { it.interfaces.any { it.name == thisInterface.name } }.associateBy { it.name }
+    types.filter { type -> type.interfaces.any { it.name == thisInterface.name } }.associateBy { it.name }
 ) {
     override fun getError(name: String) = "Expected object type with name '$name' to implement interface '${thisInterface.name}', but it doesn't!"
 }

src/main/kotlin/graphql/kickstart/tools/SchemaParser.kt

@@ -274,7 +274,7 @@ class SchemaParser internal constructor(
             if (nestedUnion != null) {
                 leafObjects.addAll(getLeafUnionObjects(nestedUnion, types))
             } else {
-                leafObjects.add(types.find { it.name == typeName }
+                leafObjects.add(types.find { type -> type.name == typeName }
                     ?: throw SchemaError("Expected object type '$typeName' for union type '$name', but found none!"))
             }
         }
@@ -386,7 +386,7 @@ class SchemaParser internal constructor(
      * Returns an optional [String] describing a deprecated field/enum.
      * If a deprecation directive was defined using the @deprecated directive,
      * then a String containing either the contents of the 'reason' argument, if present, or a default
-     * message defined in [DEFAULT_DEPRECATION_MESSAGE] will be returned. Otherwise, [null] will be returned
+     * message defined in [DEFAULT_DEPRECATION_MESSAGE] will be returned. Otherwise, `null` will be returned
      * indicating no deprecation directive was found within the directives list.
      */
     private fun getDeprecated(directives: List<Directive>): String? =

src/main/kotlin/graphql/kickstart/tools/SchemaParserOptions.kt

@@ -153,7 +153,7 @@ data class SchemaParserOptions internal constructor(
         }
     }
 
-    internal class DefaultCoroutineContextProvider(val coroutineContext: CoroutineContext) : CoroutineContextProvider {
+    internal class DefaultCoroutineContextProvider(private val coroutineContext: CoroutineContext) : CoroutineContextProvider {
         override fun provide(): CoroutineContext {
             return coroutineContext
         }

src/main/kotlin/graphql/kickstart/tools/proxy/Spring4AopProxyHandler.kt

@@ -8,7 +8,7 @@ import org.springframework.aop.support.AopUtils
  */
 class Spring4AopProxyHandler : ProxyHandler {
 
-    val isEnabled: Boolean =
+    private val isEnabled: Boolean =
         try {
             Class.forName("org.springframework.aop.support.AopUtils")
             true

src/main/kotlin/graphql/kickstart/tools/scanner/MethodFieldResolver.kt

@@ -266,7 +266,7 @@ private inline fun invoke(method: Method, instance: Any, args: Array<Any?>): Any
             throw e
         }
 
-        throw java.lang.reflect.UndeclaredThrowableException(e);
+        throw java.lang.reflect.UndeclaredThrowableException(e)
     }
 }
 

src/main/kotlin/graphql/kickstart/tools/scanner/PropertyFieldResolver.kt

@@ -13,7 +13,7 @@ internal class PropertyFieldResolver(
     field: FieldDefinition,
     search: FieldResolverScanner.Search,
     options: SchemaParserOptions,
-    val property: Field
+    private val property: Field
 ) : FieldResolver(field, search, options, property.declaringClass) {
 
     override fun createDataFetcher(): DataFetcher<*> {

src/main/kotlin/graphql/kickstart/tools/scanner/PropertyMapResolver.kt

@@ -19,15 +19,15 @@ internal class PropertyMapResolver(
     relativeTo: JavaType
 ) : FieldResolver(field, search, options, relativeTo) {
 
-    var mapGenericValue: JavaType = getMapGenericType(relativeTo)
+    private var mapGenericValue: JavaType = getMapGenericType(relativeTo)
 
     /**
      * Takes a type which implements Map and tries to find the
      * value type of that map. For some reason, mapClass is losing
      * its generics somewhere along the way and is always a raw
      * type.
      */
-    fun getMapGenericType(mapClass: JavaType): JavaType {
+    private fun getMapGenericType(mapClass: JavaType): JavaType {
         val resolvedType = TypeResolver().resolve(mapClass)
         val typeParameters = resolvedType.typeParametersFor(Map::class.java)
 
@@ -47,7 +47,7 @@ internal class PropertyMapResolver(
 
 internal class PropertyMapResolverDataFetcher(
     private val sourceResolver: SourceResolver,
-    val key: String
+    private val key: String
 ) : DataFetcher<Any> {
 
     override fun get(environment: DataFetchingEnvironment): Any? {

src/main/kotlin/graphql/kickstart/tools/scanner/RootTypeInfo.kt

@@ -7,9 +7,9 @@ import graphql.language.TypeName
  * @author Andrew Potter
  */
 internal class RootTypeInfo private constructor(
-    val queryType: TypeName?,
-    val mutationType: TypeName?,
-    val subscriptionType: TypeName?
+    private val queryType: TypeName?,
+    private val mutationType: TypeName?,
+    private val subscriptionType: TypeName?
 ) {
     companion object {
         const val DEFAULT_QUERY_NAME = "Query"

src/main/kotlin/graphql/kickstart/tools/scanner/SchemaClassScanner.kt

@@ -234,7 +234,7 @@ internal class SchemaClassScanner(
         val resolverInfo: ResolverInfo = (if (resolverInfoList.size > 1) {
             MultiResolverInfo(resolverInfoList)
         } else {
-            if (item.clazz.equals(Object::class.java)) {
+            if (item.clazz == Object::class.java) {
                 getResolverInfoFromTypeDictionary(item.type.name)
             } else {
                 resolverInfosByDataClass[item.clazz] ?: DataClassResolverInfo(item.clazz)

src/main/kotlin/graphql/kickstart/tools/util/ParameterizedTypeImpl.java

@@ -58,7 +58,7 @@ private void validateConstructorArguments() {
             throw new MalformedParameterizedTypeException();
         }
         for (int i = 0; i < actualTypeArguments.length; i++) {
-            // check actuals against formals' bounds
+            // TODO check actual against formal bounds
         }
     }