Added method which check is this request must be cached.

Author: donbeave

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/BatchedQueryResponseWriter.java

@@ -42,9 +42,9 @@ public void write(HttpServletRequest request, HttpServletResponse response, Grap
     String responseContent = responseBuilder.toString();
     byte[] contentBytes = responseContent.getBytes(StandardCharsets.UTF_8);
 
-    if (responseCache != null) {
+    if (responseCache != null && responseCache.isCacheable(request, invocationInput)) {
       try {
-        responseCache.cacheResponse(request, invocationInput, CachedResponse.ofContent(contentBytes));
+        responseCache.put(request, invocationInput, CachedResponse.ofContent(contentBytes));
       } catch (Throwable t) {
         log.warn(t.getMessage(), t);
         log.warn("Ignore read from cache, unexpected error happened");

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/ErrorQueryResponseWriter.java

@@ -20,9 +20,9 @@ class ErrorQueryResponseWriter implements QueryResponseWriter {
 
   @Override
   public void write(HttpServletRequest request, HttpServletResponse response, GraphQLResponseCache responseCache) throws IOException {
-    if (responseCache != null) {
+    if (responseCache != null && responseCache.isCacheable(request, invocationInput)) {
       try {
-        responseCache.cacheResponse(request, invocationInput, CachedResponse.ofError(statusCode, message));
+        responseCache.put(request, invocationInput, CachedResponse.ofError(statusCode, message));
       } catch (Throwable t) {
         log.warn(t.getMessage(), t);
         log.warn("Ignore read from cache, unexpected error happened");

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/SingleQueryResponseWriter.java

@@ -29,9 +29,9 @@ public void write(HttpServletRequest request, HttpServletResponse response, Grap
     String responseContent = graphQLObjectMapper.serializeResultAsJson(result);
     byte[] contentBytes = responseContent.getBytes(StandardCharsets.UTF_8);
 
-    if (responseCache != null) {
+    if (responseCache != null && responseCache.isCacheable(request, invocationInput)) {
       try {
-        responseCache.cacheResponse(request, invocationInput, CachedResponse.ofContent(contentBytes));
+        responseCache.put(request, invocationInput, CachedResponse.ofContent(contentBytes));
       } catch (Throwable t) {
         log.warn(t.getMessage(), t);
         log.warn("Ignore read from cache, unexpected error happened");

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/cache/GraphQLResponseCache.java

@@ -14,15 +14,23 @@ public interface GraphQLResponseCache {
    * @param invocationInput input data
    * @return cached response if something available in cache or {@literal null} if nothing cached
    */
-  CachedResponse getCachedResponse(HttpServletRequest request, GraphQLInvocationInput invocationInput);
+  CachedResponse get(HttpServletRequest request, GraphQLInvocationInput invocationInput);
 
   /**
    * Decide to cache or not this response. It depends on the implementation.
    *
    * @param request         the http request
    * @param invocationInput input data
+   */
+  boolean isCacheable(HttpServletRequest request, GraphQLInvocationInput invocationInput);
+
+  /**
+   * Cache this response. It depends on the implementation.
+   *
+   * @param request         the http request
+   * @param invocationInput input data
    * @param cachedResponse  response to cache
    */
-  void cacheResponse(HttpServletRequest request, GraphQLInvocationInput invocationInput, CachedResponse cachedResponse);
+  void put(HttpServletRequest request, GraphQLInvocationInput invocationInput, CachedResponse cachedResponse);
 
 }