Skip to content

Commit 883ab9e

Browse files
committed
separated out logging of errors to separate overridable method in DefaultGraphQLErrorHandler so that entire processErrors method does not need to be overridden just to change which errors get logged by users of DefaultGraphQLErrorHandler
1 parent e82a465 commit 883ab9e

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/main/java/graphql/servlet/DefaultGraphQLErrorHandler.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,22 @@ public List<GraphQLError> processErrors(List<GraphQLError> errors) {
2626

2727
errors.stream()
2828
.filter(error -> !isClientError(error))
29-
.forEach(error -> {
30-
if (error instanceof Throwable) {
31-
log.error("Error executing query!", (Throwable) error);
32-
} else if (error instanceof ExceptionWhileDataFetching) {
33-
log.error("Error executing query {}", error.getMessage(), ((ExceptionWhileDataFetching) error).getException());
34-
} else {
35-
log.error("Error executing query ({}): {}", error.getClass().getSimpleName(), error.getMessage());
36-
}
37-
});
29+
.forEach(this::logError);
3830
}
3931

4032
return clientErrors;
4133
}
4234

35+
protected void logError(GraphQLError error) {
36+
if (error instanceof Throwable) {
37+
log.error("Error executing query!", (Throwable) error);
38+
} else if (error instanceof ExceptionWhileDataFetching) {
39+
log.error("Error executing query {}", error.getMessage(), ((ExceptionWhileDataFetching) error).getException());
40+
} else {
41+
log.error("Error executing query ({}): {}", error.getClass().getSimpleName(), error.getMessage());
42+
}
43+
}
44+
4345
protected List<GraphQLError> filterGraphQLErrors(List<GraphQLError> errors) {
4446
return errors.stream()
4547
.filter(this::isClientError)

0 commit comments

Comments
 (0)