simple code analysis

Author: jmccaull

src/main/java/graphql/servlet/AbstractGraphQLHttpServlet.java

@@ -54,13 +54,13 @@
  */
 public abstract class AbstractGraphQLHttpServlet extends HttpServlet implements Servlet, GraphQLMBean {
 
-    public static final Logger log = LoggerFactory.getLogger(AbstractGraphQLHttpServlet.class);
+    private static final Logger log = LoggerFactory.getLogger(AbstractGraphQLHttpServlet.class);
 
-    public static final String APPLICATION_JSON_UTF8 = "application/json;charset=UTF-8";
-    public static final String APPLICATION_EVENT_STREAM_UTF8 = "text/event-stream;charset=UTF-8";
-    public static final String APPLICATION_GRAPHQL = "application/graphql";
-    public static final int STATUS_OK = 200;
-    public static final int STATUS_BAD_REQUEST = 400;
+    private static final String APPLICATION_JSON_UTF8 = "application/json;charset=UTF-8";
+    private static final String APPLICATION_EVENT_STREAM_UTF8 = "text/event-stream;charset=UTF-8";
+    private static final String APPLICATION_GRAPHQL = "application/graphql";
+    private static final int STATUS_OK = 200;
+    private static final int STATUS_BAD_REQUEST = 400;
 
     private static final GraphQLRequest INTROSPECTION_REQUEST = new GraphQLRequest(IntrospectionQuery.INTROSPECTION_QUERY, new HashMap<>(), null);
     private static final String[] MULTIPART_KEYS = new String[]{"operations", "graphql", "query"};

src/main/java/graphql/servlet/core/DefaultGraphQLErrorHandler.java

@@ -14,7 +14,7 @@
  */
 public class DefaultGraphQLErrorHandler implements GraphQLErrorHandler {
 
-    public static final Logger log = LoggerFactory.getLogger(DefaultGraphQLErrorHandler.class);
+    private static final Logger log = LoggerFactory.getLogger(DefaultGraphQLErrorHandler.class);
 
     @Override
     public List<GraphQLError> processErrors(List<GraphQLError> errors) {

src/main/java/graphql/servlet/core/GraphQLRootObjectBuilder.java

@@ -1,9 +1,7 @@
 package graphql.servlet.core;
 
 import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
 import javax.websocket.server.HandshakeRequest;
-import java.util.Optional;
 
 public interface GraphQLRootObjectBuilder {
     Object build(HttpServletRequest req);

src/main/java/graphql/servlet/instrumentation/ConfigurableDispatchInstrumentation.java

@@ -167,8 +167,7 @@ public CompletableFuture<ExecutionResult> instrumentExecutionResult(ExecutionRes
         }
         DataLoaderDispatcherInstrumentationState state = parameters.getInstrumentationState();
         Map<Object, Object> currentExt = executionResult.getExtensions();
-        Map<Object, Object> statsMap = new LinkedHashMap<>();
-        statsMap.putAll(currentExt == null ? Collections.emptyMap() : currentExt);
+        Map<Object, Object> statsMap = new LinkedHashMap<>(currentExt == null ? Collections.emptyMap() : currentExt);
         Map<Object, Object> dataLoaderStats = buildStatsMap(state);
         statsMap.put("dataloader", dataLoaderStats);
         state.getApproach().removeTracking(parameters.getExecutionInput().getExecutionId());

src/main/java/graphql/servlet/instrumentation/DataLoaderDispatcherInstrumentationState.java

@@ -2,7 +2,6 @@
 
 import graphql.execution.ExecutionId;
 import graphql.execution.instrumentation.InstrumentationState;
-import graphql.execution.instrumentation.dataloader.DataLoaderDispatcherInstrumentationOptions;
 import org.dataloader.DataLoaderRegistry;
 
 /**