Skip to content

Commit 236f60c

Browse files
tomqwpltomqwpl
committed
For me, jackson 2.8.11.1 couldn't be found in https://repo.maven.apache.org/maven2,
so I downgraded it to 2.8.11. I changed the group IDs of the example artifacts to com.graphql-java-kickstart from com.graphql-java to match the main artifacts I added slf4j to the feature. This now seems to be required. There now seems to be an incompatibility between the karaf maven plugin and the latest maven-install-plugin:3.0.0-M1. See https://stackoverflow.com/a/52622275/518627. So I put in specific references to the previous plugin versions in order to fix this. The change that *actually* makes the result work is to change the dependency on javax-servlet-api to be 3.1.0 in the build.gradle file. Otherwise the graphql-java-servlet depends on javax-servlet-api version 4, whereas the Pax Web Http whiteboard depends on 3.1 and so never recognises the graphql-java-servlet component.
1 parent 583f855 commit 236f60c

File tree

5 files changed

+54
-23
lines changed

5 files changed

+54
-23
lines changed

‎build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ dependencies {
5151
compileOnly 'biz.aQute.bnd:biz.aQute.bndlib:3.1.0'
5252

5353
// Servlet
54-
compile 'javax.servlet:javax.servlet-api:4.0.0'
54+
compile 'javax.servlet:javax.servlet-api:3.1.0'
5555
compile 'javax.websocket:javax.websocket-api:1.1'
5656

5757
// GraphQL

‎examples/osgi/apache-karaf-feature/pom.xml‎

Lines changed: 31 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
7-
<groupId>com.graphql-java</groupId>
7+
<groupId>com.graphql-java-kickstart</groupId>
88
<artifactId>graphql-java-servlet-osgi-examples</artifactId>
9-
<version>3.0.1</version>
9+
<version>6.2.1-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>graphql-java-servlet-osgi-examples-karaf-feature</artifactId>
@@ -17,22 +17,22 @@
1717
<dependency>
1818
<groupId>com.fasterxml.jackson.core</groupId>
1919
<artifactId>jackson-core</artifactId>
20-
<version>2.8.11.1</version>
20+
<version>2.8.11</version>
2121
</dependency>
2222
<dependency>
2323
<groupId>com.fasterxml.jackson.core</groupId>
2424
<artifactId>jackson-annotations</artifactId>
25-
<version>2.8.11.1</version>
25+
<version>2.8.11</version>
2626
</dependency>
2727
<dependency>
2828
<groupId>com.fasterxml.jackson.core</groupId>
2929
<artifactId>jackson-databind</artifactId>
30-
<version>2.8.11.1</version>
30+
<version>2.8.11</version>
3131
</dependency>
3232
<dependency>
3333
<groupId>com.fasterxml.jackson.datatype</groupId>
3434
<artifactId>jackson-datatype-jdk8</artifactId>
35-
<version>2.8.11.1</version>
35+
<version>2.8.11</version>
3636
</dependency>
3737
<dependency>
3838
<groupId>com.google.guava</groupId>
@@ -47,11 +47,11 @@
4747
<dependency>
4848
<groupId>org.antlr</groupId>
4949
<artifactId>antlr4-runtime</artifactId>
50-
<version>4.5.1</version>
50+
<version>4.7.1</version>
5151
</dependency>
5252

5353
<dependency>
54-
<groupId>com.graphql-java</groupId>
54+
<groupId>com.graphql-java-kickstart</groupId>
5555
<artifactId>graphql-java-servlet</artifactId>
5656
<version>${graphql.java.servlet.version}</version>
5757
</dependency>
@@ -67,11 +67,20 @@
6767
</dependency>
6868

6969
<dependency>
70-
<groupId>com.graphql-java</groupId>
70+
<groupId>com.graphql-java-kickstart</groupId>
7171
<artifactId>graphql-java-servlet-osgi-examples-providers</artifactId>
7272
<version>${project.version}</version>
7373
</dependency>
74-
74+
<dependency>
75+
<groupId>org.slf4j</groupId>
76+
<artifactId>slf4j-api</artifactId>
77+
<version>1.7.25</version>
78+
</dependency>
79+
<dependency>
80+
<groupId>org.slf4j</groupId>
81+
<artifactId>slf4j-log4j12</artifactId>
82+
<version>1.7.25</version>
83+
</dependency>
7584
</dependencies>
7685

7786
<build>
@@ -87,7 +96,18 @@
8796
<includeTransitiveDependency>true</includeTransitiveDependency>
8897
</configuration>
8998
</plugin>
90-
</plugins>
99+
100+
<plugin>
101+
<groupId>org.apache.maven.plugins</groupId>
102+
<artifactId>maven-install-plugin</artifactId>
103+
<version>2.5.2</version>
104+
</plugin>
105+
<plugin>
106+
<groupId>org.apache.maven.plugins</groupId>
107+
<artifactId>maven-deploy-plugin</artifactId>
108+
<version>2.8.2</version>
109+
</plugin>
110+
</plugins>
91111

92112
</build>
93113

‎examples/osgi/apache-karaf-package/pom.xml‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
7-
<groupId>com.graphql-java</groupId>
7+
<groupId>com.graphql-java-kickstart</groupId>
88
<artifactId>graphql-java-servlet-osgi-examples</artifactId>
9-
<version>3.0.1</version>
9+
<version>6.2.1-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>graphql-java-servlet-osgi-examples-apache-karaf-package</artifactId>
@@ -40,7 +40,7 @@
4040
</dependency>
4141

4242
<dependency>
43-
<groupId>com.graphql-java</groupId>
43+
<groupId>com.graphql-java-kickstart</groupId>
4444
<artifactId>graphql-java-servlet-osgi-examples-karaf-feature</artifactId>
4545
<version>${project.version}</version>
4646
<classifier>features</classifier>
@@ -99,6 +99,17 @@
9999
</installedFeatures>
100100
</configuration>
101101
</plugin>
102-
</plugins>
102+
103+
<plugin>
104+
<groupId>org.apache.maven.plugins</groupId>
105+
<artifactId>maven-install-plugin</artifactId>
106+
<version>2.5.2</version>
107+
</plugin>
108+
<plugin>
109+
<groupId>org.apache.maven.plugins</groupId>
110+
<artifactId>maven-deploy-plugin</artifactId>
111+
<version>2.8.2</version>
112+
</plugin>
113+
</plugins>
103114
</build>
104115
</project>

‎examples/osgi/pom.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66

7-
<groupId>com.graphql-java</groupId>
7+
<groupId>com.graphql-java-kickstart</groupId>
88
<artifactId>graphql-java-servlet-osgi-examples</artifactId>
9-
<version>3.0.1</version>
9+
<version>6.2.1-SNAPSHOT</version>
1010
<packaging>pom</packaging>
1111

1212
<properties>
1313
<karaf.version>4.1.6</karaf.version>
14-
<graphql.java.servlet.version>3.0.1</graphql.java.servlet.version>
15-
<graphql.java.version>2.4.0</graphql.java.version>
14+
<graphql.java.servlet.version>6.2.1-SNAPSHOT</graphql.java.servlet.version>
15+
<graphql.java.version>10.0</graphql.java.version>
1616
</properties>
1717

1818
<modules>

‎examples/osgi/providers/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
7-
<groupId>com.graphql-java</groupId>
7+
<groupId>com.graphql-java-kickstart</groupId>
88
<artifactId>graphql-java-servlet-osgi-examples</artifactId>
9-
<version>3.0.1</version>
9+
<version>6.2.1-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>graphql-java-servlet-osgi-examples-providers</artifactId>
1313
<packaging>bundle</packaging>
1414

1515
<dependencies>
1616
<dependency>
17-
<groupId>com.graphql-java</groupId>
17+
<groupId>com.graphql-java-kickstart</groupId>
1818
<artifactId>graphql-java-servlet</artifactId>
1919
<version>${graphql.java.servlet.version}</version>
2020
<scope>provided</scope>

0 commit comments

Comments
 (0)