-
-
Notifications
You must be signed in to change notification settings - Fork 206
Add patch package to apply diff changes to schemas #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolle
commented
Jul 8, 2025
jdolle
commented
Jul 8, 2025
jdolle
commented
Jul 9, 2025
jdolle
commented
Jul 9, 2025
jdolle
commented
Jul 9, 2025
jdolle
commented
Jul 9, 2025
jdolle
commented
Jul 9, 2025
jdolle
commented
Jul 24, 2025
dotansimha
reviewed
Nov 2, 2025
dotansimha
approved these changes
Nov 2, 2025
Member
dotansimha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added a few minor comments, mainly around release pipeline.
We can proceed once @n1ru4l confirms it's good to go.
Thanks!
n1ru4l
reviewed
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change began as one to only the adds fields that are necessary for recreating the patched schema using the input schema and changes array, but it has expanded to also add the patch functionality. I found this was necessary in order to verify that the changes provided sufficient data.
This PR modifies the several change types, and modifies the
onAddedhandlers to also execute equivalent logic toonMutual. It also adds a new rule that can be added to filter out these additional changes, thus keeping changelogs to a minimum. Paths also needed changed to consistently and uniquely map to the node being changed. Previously, some changes referenced a parent's coordinate. Lastly, directives support was dramatically improved and the directive path was modified to include@to distinguish it from any other node potentially with the same name.The expansion of "onAdded" has a few down sides and an important up side.
Cons
onAddedcall. Because e.g. adding an interface to newly create object is completely safe, but adding an interface to an existing object is considered dangerous.Pro
Type of change
How Has This Been Tested?
See unit tests.
Checklist:
CONTRIBUTING doc and the
style guidelines of this project