Console 1526 deprecation confusion in explorer (#7327)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: jonathanawesome

packages/web/app/src/components/target/explorer/common.tsx

@@ -205,19 +205,16 @@ const GraphQLTypeCard_SupergraphMetadataFragment = graphql(`
 
 export function DeprecationNote(props: {
   deprecationReason: string | null | undefined;
-  styleDeprecated: boolean;
   children: ReactNode;
 }) {
   if (!props.deprecationReason) {
     return <>{props.children}</>;
   }
 
   return (
-    <TooltipProvider delayDuration={100}>
+    <TooltipProvider delayDuration={0}>
       <Tooltip>
-        <TooltipTrigger
-          className={cn(props.styleDeprecated ? 'line-through hover:line-through' : '')}
-        >
+        <TooltipTrigger className="line-through hover:line-through">
           {props.children}
         </TooltipTrigger>
         <TooltipContent className="min-w-6 max-w-screen-md" side="right" sideOffset={5}>
@@ -331,7 +328,6 @@ export function GraphQLInputFields(props: {
   targetSlug: string;
   projectSlug: string;
   organizationSlug: string;
-  styleDeprecated: boolean;
 }): ReactElement {
   const fields = useFragment(GraphQLInputFields_InputFieldFragment, props.fields);
 
@@ -348,10 +344,7 @@ export function GraphQLInputFields(props: {
             <div>
               <div className="flex w-full flex-row items-center justify-between">
                 <div className="text-gray-400">
-                  <DeprecationNote
-                    styleDeprecated={props.styleDeprecated}
-                    deprecationReason={field.deprecationReason}
-                  >
+                  <DeprecationNote deprecationReason={field.deprecationReason}>
                     <LinkToCoordinatePage
                       organizationSlug={props.organizationSlug}
                       projectSlug={props.projectSlug}

packages/web/app/src/components/target/explorer/enum-type.tsx

@@ -46,7 +46,6 @@ export function GraphQLEnumTypeComponent(props: {
   organizationSlug: string;
   projectSlug: string;
   targetSlug: string;
-  styleDeprecated: boolean;
 }) {
   const router = useRouter();
   const searchObj = router.latestLocation.search;
@@ -86,10 +85,7 @@ export function GraphQLEnumTypeComponent(props: {
         {values.map((value, i) => (
           <GraphQLTypeCardListItem key={value.name} index={i}>
             <div className="flex flex-col">
-              <DeprecationNote
-                styleDeprecated={props.styleDeprecated}
-                deprecationReason={value.deprecationReason}
-              >
+              <DeprecationNote deprecationReason={value.deprecationReason}>
                 <LinkToCoordinatePage
                   organizationSlug={props.organizationSlug}
                   projectSlug={props.projectSlug}

packages/web/app/src/components/target/explorer/graphql-arguments.tsx

@@ -15,7 +15,6 @@ export const GraphQLArguments_ArgumentFragment = graphql(`
 export function GraphQLArguments(props: {
   parentCoordinate: string;
   args: FragmentType<typeof GraphQLArguments_ArgumentFragment>[];
-  styleDeprecated: boolean;
   organizationSlug: string;
   projectSlug: string;
   targetSlug: string;
@@ -32,10 +31,7 @@ export function GraphQLArguments(props: {
           const coordinate = `${props.parentCoordinate}.${arg.name}`;
           return (
             <div key={arg.name}>
-              <DeprecationNote
-                styleDeprecated={props.styleDeprecated}
-                deprecationReason={arg.deprecationReason}
-              >
+              <DeprecationNote deprecationReason={arg.deprecationReason}>
                 <LinkToCoordinatePage
                   organizationSlug={props.organizationSlug}
                   projectSlug={props.projectSlug}

packages/web/app/src/components/target/explorer/graphql-fields.tsx

@@ -41,7 +41,6 @@ export function GraphQLFields(props: {
   organizationSlug: string;
   warnAboutUnusedArguments: boolean;
   warnAboutDeprecatedArguments: boolean;
-  styleDeprecated: boolean;
 }) {
   const { totalRequests } = props;
   const fieldsFromFragment = useFragment(GraphQLFields_FieldFragment, props.fields);
@@ -88,10 +87,7 @@ export function GraphQLFields(props: {
                         </TooltipTrigger>
                       </Tooltip>
                     )}
-                    <DeprecationNote
-                      styleDeprecated={props.styleDeprecated}
-                      deprecationReason={field.deprecationReason}
-                    >
+                    <DeprecationNote deprecationReason={field.deprecationReason}>
                       <LinkToCoordinatePage
                         organizationSlug={props.organizationSlug}
                         projectSlug={props.projectSlug}
@@ -107,7 +103,6 @@ export function GraphQLFields(props: {
                         organizationSlug={props.organizationSlug}
                         projectSlug={props.projectSlug}
                         targetSlug={props.targetSlug}
-                        styleDeprecated={props.styleDeprecated}
                         parentCoordinate={coordinate}
                         args={field.args}
                       />

packages/web/app/src/components/target/explorer/input-object-type.tsx

@@ -23,7 +23,6 @@ export function GraphQLInputObjectTypeComponent(props: {
   organizationSlug: string;
   projectSlug: string;
   targetSlug: string;
-  styleDeprecated: boolean;
 }) {
   const ttype = useFragment(GraphQLInputObjectTypeComponent_TypeFragment, props.type);
   return (
@@ -45,7 +44,6 @@ export function GraphQLInputObjectTypeComponent(props: {
         targetSlug={props.targetSlug}
         projectSlug={props.projectSlug}
         organizationSlug={props.organizationSlug}
-        styleDeprecated={props.styleDeprecated}
       />
     </GraphQLTypeCard>
   );

packages/web/app/src/components/target/explorer/interface-type.tsx

@@ -27,7 +27,6 @@ export function GraphQLInterfaceTypeComponent(props: {
   targetSlug: string;
   warnAboutUnusedArguments: boolean;
   warnAboutDeprecatedArguments: boolean;
-  styleDeprecated: boolean;
 }) {
   const ttype = useFragment(GraphQLInterfaceTypeComponent_TypeFragment, props.type);
   return (
@@ -50,7 +49,6 @@ export function GraphQLInterfaceTypeComponent(props: {
         organizationSlug={props.organizationSlug}
         warnAboutDeprecatedArguments={props.warnAboutDeprecatedArguments}
         warnAboutUnusedArguments={props.warnAboutUnusedArguments}
-        styleDeprecated={props.styleDeprecated}
       />
     </GraphQLTypeCard>
   );

packages/web/app/src/components/target/explorer/object-type.tsx

@@ -27,7 +27,6 @@ export function GraphQLObjectTypeComponent(props: {
   targetSlug: string;
   warnAboutUnusedArguments: boolean;
   warnAboutDeprecatedArguments: boolean;
-  styleDeprecated: boolean;
 }) {
   const ttype = useFragment(GraphQLObjectTypeComponent_TypeFragment, props.type);
 
@@ -51,7 +50,6 @@ export function GraphQLObjectTypeComponent(props: {
         organizationSlug={props.organizationSlug}
         warnAboutDeprecatedArguments={props.warnAboutDeprecatedArguments}
         warnAboutUnusedArguments={props.warnAboutUnusedArguments}
-        styleDeprecated={props.styleDeprecated}
       />
     </GraphQLTypeCard>
   );

packages/web/app/src/pages/target-explorer-deprecated.tsx

@@ -146,7 +146,6 @@ const DeprecatedSchemaView = memo(function _DeprecatedSchemaView(props: {
               targetSlug={props.targetSlug}
               warnAboutDeprecatedArguments
               warnAboutUnusedArguments={false}
-              styleDeprecated={false}
             />
           );
         })}

packages/web/app/src/pages/target-explorer-type.tsx

@@ -49,7 +49,6 @@ export function TypeRenderer(props: {
   targetSlug: string;
   warnAboutUnusedArguments: boolean;
   warnAboutDeprecatedArguments: boolean;
-  styleDeprecated: boolean;
 }) {
   const ttype = useFragment(TypeRenderFragment, props.type);
   switch (ttype.__typename) {
@@ -63,7 +62,6 @@ export function TypeRenderer(props: {
           organizationSlug={props.organizationSlug}
           warnAboutUnusedArguments={props.warnAboutUnusedArguments}
           warnAboutDeprecatedArguments={props.warnAboutDeprecatedArguments}
-          styleDeprecated={props.styleDeprecated}
         />
       );
     case 'GraphQLInterfaceType':
@@ -76,7 +74,6 @@ export function TypeRenderer(props: {
           organizationSlug={props.organizationSlug}
           warnAboutUnusedArguments={props.warnAboutUnusedArguments}
           warnAboutDeprecatedArguments={props.warnAboutDeprecatedArguments}
-          styleDeprecated={props.styleDeprecated}
         />
       );
     case 'GraphQLUnionType':
@@ -97,7 +94,6 @@ export function TypeRenderer(props: {
           targetSlug={props.targetSlug}
           projectSlug={props.projectSlug}
           organizationSlug={props.organizationSlug}
-          styleDeprecated={props.styleDeprecated}
         />
       );
     case 'GraphQLInputObjectType':
@@ -108,7 +104,6 @@ export function TypeRenderer(props: {
           targetSlug={props.targetSlug}
           projectSlug={props.projectSlug}
           organizationSlug={props.organizationSlug}
-          styleDeprecated={props.styleDeprecated}
         />
       );
     case 'GraphQLScalarType':
@@ -264,7 +259,6 @@ function TypeExplorerPageContent(props: {
           targetSlug={props.targetSlug}
           warnAboutDeprecatedArguments={false}
           warnAboutUnusedArguments={false}
-          styleDeprecated
         />
       ) : type ? (
         <NoSchemaVersion

packages/web/app/src/pages/target-explorer-unused.tsx

@@ -205,7 +205,6 @@ const UnusedSchemaView = memo(function _UnusedSchemaView(props: {
               targetSlug={props.targetSlug}
               warnAboutDeprecatedArguments={false}
               warnAboutUnusedArguments
-              styleDeprecated
             />
           );
         })}