More tests

Author: David Koblas

handler_test.go

@@ -389,9 +389,6 @@ func TestHandler_Multipart_Basic_Upload(t *testing.T) {
 	if resp.Code != http.StatusOK {
 		t.Fatalf("unexpected server response %v", resp.Code)
 	}
-	if resp.Code != http.StatusOK {
-		t.Fatalf("unexpected server response %v", resp.Code)
-	}
 	if !reflect.DeepEqual(result, expected) {
 		t.Fatalf("wrong result, graphql result diff: %v", testutil.Diff(expected, result))
 	}
@@ -442,10 +439,118 @@ func TestHandler_Multipart_Basic_UploadSlice(t *testing.T) {
 	if resp.Code != http.StatusOK {
 		t.Fatalf("unexpected server response %v", resp.Code)
 	}
+	if !reflect.DeepEqual(result, expected) {
+		t.Fatalf("wrong result, graphql result diff: %v", testutil.Diff(expected, result))
+	}
+}
+
+func TestHandler_Multipart_Basic_BadSlice(t *testing.T) {
+	body := &bytes.Buffer{}
+	writer := multipart.NewWriter(body)
+
+	queryString := `{
+		"query":"query HeroNameQuery { hero { name } }",
+		"variables":{"file":[null,null]}
+	}`
+
+	writer.WriteField("operations", queryString)
+	writer.WriteField("map", `{"0":["variables.file.x"]}`)
+
+	part, _ := writer.CreateFormFile("0", "test.txt")
+	if _, err := io.Copy(part, strings.NewReader("How now brown cow")); err != nil {
+		t.Fatalf("unexpected copy writer fail %v", err)
+	}
+
+	err := writer.Close()
+	if err != nil {
+		t.Fatalf("unexpected writer fail %v", err)
+	}
+
+	req, err := http.NewRequest("POST", "/graphql", body)
+	req.Header.Set("Content-Type", writer.FormDataContentType())
+
+	h := handler.New(&handler.Config{
+		Schema: &testutil.StarWarsSchema,
+	})
+	result, resp := executeTest(t, h, req)
 	if resp.Code != http.StatusOK {
 		t.Fatalf("unexpected server response %v", resp.Code)
 	}
-	if !reflect.DeepEqual(result, expected) {
-		t.Fatalf("wrong result, graphql result diff: %v", testutil.Diff(expected, result))
+	if len(result.Errors) != 1 || result.Errors[0].Message != "Must provide an operation." {
+		t.Fatalf("unexpected response %+v", result)
+	}
+}
+
+func TestHandler_Multipart_Basic_BadSliceLast(t *testing.T) {
+	body := &bytes.Buffer{}
+	writer := multipart.NewWriter(body)
+
+	queryString := `{
+		"query":"query HeroNameQuery { hero { name } }",
+		"variables":{"file":[null,null]}
+	}`
+
+	writer.WriteField("operations", queryString)
+	writer.WriteField("map", `{"0":["variables.file.0.test"]}`)
+
+	part, _ := writer.CreateFormFile("0", "test.txt")
+	if _, err := io.Copy(part, strings.NewReader("How now brown cow")); err != nil {
+		t.Fatalf("unexpected copy writer fail %v", err)
+	}
+
+	err := writer.Close()
+	if err != nil {
+		t.Fatalf("unexpected writer fail %v", err)
+	}
+
+	req, err := http.NewRequest("POST", "/graphql", body)
+	req.Header.Set("Content-Type", writer.FormDataContentType())
+
+	h := handler.New(&handler.Config{
+		Schema: &testutil.StarWarsSchema,
+	})
+	result, resp := executeTest(t, h, req)
+	if resp.Code != http.StatusOK {
+		t.Fatalf("unexpected server response %v", resp.Code)
+	}
+	if len(result.Errors) != 1 || result.Errors[0].Message != "Must provide an operation." {
+		t.Fatalf("unexpected response %+v", result)
+	}
+}
+
+func TestHandler_Multipart_Basic_BadSliceMiddle(t *testing.T) {
+	body := &bytes.Buffer{}
+	writer := multipart.NewWriter(body)
+
+	queryString := `{
+		"query":"query HeroNameQuery { hero { name } }",
+		"variables":{"file":[null,null]}
+	}`
+
+	writer.WriteField("operations", queryString)
+	writer.WriteField("map", `{"0":["variables.file.x.test"]}`)
+
+	part, _ := writer.CreateFormFile("0", "test.txt")
+	if _, err := io.Copy(part, strings.NewReader("How now brown cow")); err != nil {
+		t.Fatalf("unexpected copy writer fail %v", err)
+	}
+
+	err := writer.Close()
+	if err != nil {
+		t.Fatalf("unexpected writer fail %v", err)
+	}
+
+	req, err := http.NewRequest("POST", "/graphql", body)
+	req.Header.Set("Content-Type", writer.FormDataContentType())
+
+	h := handler.New(&handler.Config{
+		Schema: &testutil.StarWarsSchema,
+	})
+	result, resp := executeTest(t, h, req)
+	if resp.Code != http.StatusOK {
+		t.Fatalf("unexpected server response %v", resp.Code)
+	}
+	if len(result.Errors) != 1 || result.Errors[0].Message != "Must provide an operation." {
+		t.Fatalf("unexpected response %+v", result)
 	}
 }