🐛 Fixed gql generation of empty arguments as ()

Author: aexol

package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphql-js-tree",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "private": false,
   "license": "MIT",
   "description": "GraphQL Parser providing simplier structure",

src/GqlParser/GqlParserTreeToGql.ts

@@ -20,13 +20,13 @@ export const parseGqlTree = (mainTree: GqlParserTree) => {
     return tree.name || '';
   };
   const generateChildren = (tree: GqlParserTree): string => {
-    return `${tree.children ? `{\n ${tree.children.map(generateGql).join('\n ')}\n}` : ''}`;
+    return `${tree.children?.length ? `{\n ${tree.children.map(generateGql).join('\n ')}\n}` : ''}`;
   };
   const generateValue = (tree: GqlParserTree): string => {
     return `${tree.value ? `: ${getValueAsGqlStringNode(tree.value)}` : ''}`;
   };
   const generateArguments = (tree: GqlParserTree): string => {
-    return `${tree.arguments ? `(\n ${tree.arguments.map((a) => generateGql(a)).join(', ')})` : ''}`;
+    return `${tree.arguments?.length ? `(\n ${tree.arguments.map((a) => generateGql(a)).join(', ')})` : ''}`;
   };
   const generateGql = (tree: GqlParserTree): string => {
     return `${generateName(tree)}${generateValue(tree)}${generateArguments(tree)}${generateChildren(tree)}`;
@@ -57,25 +57,29 @@ export const enrichFieldNodeWithVariables = (
   ) {
     return {
       ...fieldTree,
-      arguments: fieldTree.node.args.map((a) => {
-        const VarName = `${fieldTree.name}_${a.name}`;
-        const VarNode: GqlParserTree = {
-          name: a.name,
-          node: a,
-          value: {
-            kind: 'Variable',
-            value: VarName,
-          },
-        };
-        variableDefinitionsUpdate((variableDefinitions) => [
-          ...variableDefinitions,
-          {
-            name: VarName,
-            type: compileType(a.type.fieldType),
-          },
-        ]);
-        return VarNode;
-      }),
+      ...(fieldTree.node.args.length
+        ? {
+            arguments: fieldTree.node.args.map((a) => {
+              const VarName = `${fieldTree.name}_${a.name}`;
+              const VarNode: GqlParserTree = {
+                name: a.name,
+                node: a,
+                value: {
+                  kind: 'Variable',
+                  value: VarName,
+                },
+              };
+              variableDefinitionsUpdate((variableDefinitions) => [
+                ...variableDefinitions,
+                {
+                  name: VarName,
+                  type: compileType(a.type.fieldType),
+                },
+              ]);
+              return VarNode;
+            }),
+          }
+        : {}),
     };
   }
   return fieldTree;

src/GqlParser/index.ts

@@ -18,7 +18,7 @@ import {
   InlineFragmentNode,
 } from 'graphql';
 export const parseGql = (gql: string, schema: string) => {
-  const { definitions } = parse(schema + '\n' + gql);
+  const { definitions } = parse(schema + '\n' + gql, { noLocation: true });
   const ops = definitions.filter(onlyOperations);
   const frags = definitions.filter(onlyFragments);
   const { nodes } = Parser.parse(schema);