Fix some exception handling bugs (#759)

Shane32 · web-flow · commit e09157f13483 · 2022-03-28T12:51:42.000-04:00
diff --git a/src/Transports.AspNetCore/GraphQLHttpMiddleware.cs b/src/Transports.AspNetCore/GraphQLHttpMiddleware.cs
@@ -129,6 +129,7 @@ public virtual async Task InvokeAsync(HttpContext context, RequestDelegate next)
                             {
                                 if (!await HandleDeserializationErrorAsync(context, ex))
                                     throw;
+                                return;
                             }
                             break;
                         }
@@ -142,7 +143,17 @@ public virtual async Task InvokeAsync(HttpContext context, RequestDelegate next)
             GraphQLRequest gqlRequest = null;
             if (bodyGQLBatchRequest == null)
             {
-                var urlGQLRequest = DeserializeFromQueryString(httpRequest.Query);
+                GraphQLRequest urlGQLRequest = null;
+                try
+                {
+                    urlGQLRequest = DeserializeFromQueryString(httpRequest.Query);
+                }
+                catch (Exception ex)
+                {
+                    if (!await HandleDeserializationErrorAsync(context, ex))
+                        throw;
+                    return;
+                }
 
                 gqlRequest = new GraphQLRequest
                 {

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,7 @@ public virtual async Task InvokeAsync(HttpContext context, RequestDelegate next)`
`129`	`129`	`{`
`130`	`130`	`if (!await HandleDeserializationErrorAsync(context, ex))`
`131`	`131`	`throw;`
	`132`	`+ return;`
`132`	`133`	`}`
`133`	`134`	`break;`
`134`	`135`	`}`
`@@ -142,7 +143,17 @@ public virtual async Task InvokeAsync(HttpContext context, RequestDelegate next)`
`142`	`143`	`GraphQLRequest gqlRequest = null;`
`143`	`144`	`if (bodyGQLBatchRequest == null)`
`144`	`145`	`{`
`145`		`- var urlGQLRequest = DeserializeFromQueryString(httpRequest.Query);`
	`146`	`+ GraphQLRequest urlGQLRequest = null;`
	`147`	`+ try`
	`148`	`+ {`
	`149`	`+ urlGQLRequest = DeserializeFromQueryString(httpRequest.Query);`
	`150`	`+ }`
	`151`	`+ catch (Exception ex)`
	`152`	`+ {`
	`153`	`+ if (!await HandleDeserializationErrorAsync(context, ex))`
	`154`	`+ throw;`
	`155`	`+ return;`
	`156`	`+ }`
`146`	`157`
`147`	`158`	`gqlRequest = new GraphQLRequest`
`148`	`159`	`{`